Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: src/ic/handler-compiler.cc

Issue 1633213003: Remove FieldType::Iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Cleanup Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ic/handler-compiler.h" 5 #include "src/ic/handler-compiler.h"
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-inl.h" 9 #include "src/ic/ic-inl.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 504
505 GenerateRestoreName(&miss, name); 505 GenerateRestoreName(&miss, name);
506 PopVectorAndSlot(); 506 PopVectorAndSlot();
507 TailCallBuiltin(masm(), MissBuiltin(kind())); 507 TailCallBuiltin(masm(), MissBuiltin(kind()));
508 508
509 return GetCode(kind(), Code::FAST, name); 509 return GetCode(kind(), Code::FAST, name);
510 } 510 }
511 511
512 bool NamedStoreHandlerCompiler::RequiresFieldTypeChecks( 512 bool NamedStoreHandlerCompiler::RequiresFieldTypeChecks(
513 FieldType* field_type) const { 513 FieldType* field_type) const {
514 return !field_type->Classes().Done(); 514 return field_type->IsClass();
515 } 515 }
516 516
517 517
518 Handle<Code> NamedStoreHandlerCompiler::CompileStoreField(LookupIterator* it) { 518 Handle<Code> NamedStoreHandlerCompiler::CompileStoreField(LookupIterator* it) {
519 Label miss; 519 Label miss;
520 DCHECK(it->representation().IsHeapObject()); 520 DCHECK(it->representation().IsHeapObject());
521 521
522 FieldType* field_type = *it->GetFieldType(); 522 FieldType* field_type = *it->GetFieldType();
523 bool need_save_restore = false; 523 bool need_save_restore = false;
524 if (RequiresFieldTypeChecks(field_type)) { 524 if (RequiresFieldTypeChecks(field_type)) {
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 : kNoExtraICState); 603 : kNoExtraICState);
604 cached_stub = LoadDictionaryElementStub(isolate(), state).GetCode(); 604 cached_stub = LoadDictionaryElementStub(isolate(), state).GetCode();
605 } 605 }
606 } 606 }
607 607
608 handlers->Add(cached_stub); 608 handlers->Add(cached_stub);
609 } 609 }
610 } 610 }
611 } // namespace internal 611 } // namespace internal
612 } // namespace v8 612 } // namespace v8
OLDNEW
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698