Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1633203003: cc: Fix nullptr dereference when capturing skps. (Closed)

Created:
4 years, 11 months ago by vmpstr
Modified:
4 years, 11 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix nullptr dereference when capturing skps. We capture sk picture from PictureLayer, which happens before we had a chance to set the image decode controller during commit. The fix here is not to use PlaybackToCanvas, but rather use other functions to accomplish the same goal. PlaybackToCanvas should only be called after commit. R=enne BUG=581107 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6abc838bd4fed2d0e0eef80febbda07aa0190644 Cr-Commit-Position: refs/heads/master@{#371655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M cc/playback/display_list_raster_source.h View 1 chunk +5 lines, -1 line 0 comments Download
M cc/playback/display_list_raster_source.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
vmpstr
Please take a look.
4 years, 11 months ago (2016-01-26 21:50:42 UTC) #2
enne (OOO)
lgtm
4 years, 11 months ago (2016-01-26 21:57:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633203003/1
4 years, 11 months ago (2016-01-26 21:58:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/82110)
4 years, 11 months ago (2016-01-26 23:27:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633203003/1
4 years, 11 months ago (2016-01-26 23:30:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:19:14 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:20:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6abc838bd4fed2d0e0eef80febbda07aa0190644
Cr-Commit-Position: refs/heads/master@{#371655}

Powered by Google App Engine
This is Rietveld 408576698