Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: cc/playback/display_list_raster_source.h

Issue 1633203003: cc: Fix nullptr dereference when capturing skps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/playback/display_list_raster_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_list_raster_source.h
diff --git a/cc/playback/display_list_raster_source.h b/cc/playback/display_list_raster_source.h
index 73c7a7f50ac6c37b7bbba5a2ced37c99d53a6e66..9ebfd4fb657d67b27f54b37cde5f26453b16a3fa 100644
--- a/cc/playback/display_list_raster_source.h
+++ b/cc/playback/display_list_raster_source.h
@@ -36,7 +36,11 @@ class CC_EXPORT DisplayListRasterSource
// rasterizing to the stats if the respective pointer is not nullptr.
// It is assumed that the canvas passed here will only be rasterized by
// this raster source via this call.
- // virtual for testing.
+ //
+ // Virtual for testing.
+ //
+ // Note that this should only be called after the image decode controller has
+ // been set, which happens during commit.
virtual void PlaybackToCanvas(SkCanvas* canvas,
const gfx::Rect& canvas_bitmap_rect,
const gfx::Rect& canvas_playback_rect,
« no previous file with comments | « no previous file | cc/playback/display_list_raster_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698