cc :: Reland compute if layer is drawn from property trees

cc :: Reland compute if layer is drawn from property trees

This CL :
  * deletes is_hidden
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001 (http://crrev.com/1588093004#ps250001)

Committed: https://crrev.com/8665451221d678b75feeebbea51fd780148aa2cc
Cr-Commit-Position: refs/heads/master@{#371807}

[jaydasika, 2016-01-26 20:23:25]

Description was changed from

==========
cc :: Reland compute if layer is drawn from property trees


This CL :   * deletes is_hidden   * computes if a layer is drawn using the
effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7
Cr-Commit-Position: refs/heads/master@{#371063}

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

to

==========
cc :: Reland compute if layer is drawn from property trees


This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7
Cr-Commit-Position: refs/heads/master@{#371063}

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

[jaydasika, 2016-01-26 20:24:13]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 20:24:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633203002/1

[jaydasika, 2016-01-26 20:26:08]

Description was changed from

==========
cc :: Reland compute if layer is drawn from property trees


This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7
Cr-Commit-Position: refs/heads/master@{#371063}

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

to

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7
Cr-Commit-Position: refs/heads/master@{#371063}

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

[commit-bot: I haz the power, 2016-01-26 21:12:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 21:12:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jaydasika, 2016-01-26 21:40:31]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 21:40:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633203002/20001

[jaydasika, 2016-01-26 23:13:39]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-01-26 23:13:40]

There's one case that was missing in the original patch and I am confident
that's the reason for all the crashes in Win Canary (I was able to locally
reproduce the same crash stack with a unit test).

Added code for the missing case and a test.

https://codereview.chromium.org/1633203002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/1633203002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_common_unittest.cc:5189: // If the root itself is
hidden, the child should not be drawn even if it has
Unit test for the new case.

https://codereview.chromium.org/1633203002/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/1633203002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:1106: else if
(node->data.screen_space_opacity_is_animating)
When the screen space opacity is animating, we need to draw the layer even if
has a opacity 0. But, we should not draw it if the parent node is not drawn.

If we have A->B , A's opacity = 0 and B has animating opacity, B's render
surface = A,
A is not drawn and so its not part of RSLL. So, B also should not be drawn. 
(We were drawing B in the original patch, but its render surface is not in RSLL.
So in CreateRenderPasses, this was causing crashes when we try to draw the
layer).

[commit-bot: I haz the power, 2016-01-26 23:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:14:49]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-01-26 23:58:13]

Description was changed from

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5bd215b33e6343d8ae7e52fb822dd552bf8b59a7
Cr-Commit-Position: refs/heads/master@{#371063}

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

to

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

[ajuma, 2016-01-27 00:12:30]

lgtm

Just so you know for future re-lands, if you upload the previously landed patch
set as patch set 1, and then the upload the fixed version, it becomes easier to
see what changed.

[jaydasika, 2016-01-27 16:53:40]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-01-27 16:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1633203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1633203002/20001

[commit-bot: I haz the power, 2016-01-27 17:05:16]

Description was changed from

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

to

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

[commit-bot: I haz the power, 2016-01-27 17:05:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 17:06:22]

Description was changed from

==========
cc :: Reland compute if layer is drawn from property trees

This CL :   
  * deletes is_hidden   
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)
==========

to

==========
cc :: Reland compute if layer is drawn from property trees

This CL :
  * deletes is_hidden
  * computes if a layer is drawn using the effect tree

BUG=575413
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1588093004 at patchset 250001
(http://crrev.com/1588093004#ps250001)

Committed: https://crrev.com/8665451221d678b75feeebbea51fd780148aa2cc
Cr-Commit-Position: refs/heads/master@{#371807}
==========

[commit-bot: I haz the power, 2016-01-27 17:06:23]

Patchset 2 (id:??) landed as
https://crrev.com/8665451221d678b75feeebbea51fd780148aa2cc
Cr-Commit-Position: refs/heads/master@{#371807}