Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1633123002: Notifications: icon url is USVString. (Closed)

Created:
4 years, 11 months ago by Michael van Ouwerkerk
Modified:
4 years, 11 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notifications: icon url is USVString. See: https://notifications.spec.whatwg.org/#api Committed: https://crrev.com/827116aae842f168456b06d6390dfc7ca6333ef8 Cr-Commit-Position: refs/heads/master@{#371514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationOptions.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 11 months ago (2016-01-26 14:08:28 UTC) #2
Peter Beverloo
lgtm
4 years, 11 months ago (2016-01-26 14:41:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633123002/1
4 years, 11 months ago (2016-01-26 14:42:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 15:26:40 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 15:27:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/827116aae842f168456b06d6390dfc7ca6333ef8
Cr-Commit-Position: refs/heads/master@{#371514}

Powered by Google App Engine
This is Rietveld 408576698