third_party/WebKit/Source/modules/notifications/Notification.idl - Issue 1633123002: Notifications: icon url is USVString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.idl

Issue 1633123002: Notifications: icon url is USVString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.idl

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.idl b/third_party/WebKit/Source/modules/notifications/Notification.idl

index b985e3db1a107d90252d4794f385f64834c1bb7a..24310c148a140cd3f18d9ad96c0cfeb547da73da 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.idl

+++ b/third_party/WebKit/Source/modules/notifications/Notification.idl

@@ -65,7 +65,7 @@ enum NotificationPermission {

readonly attribute DOMString lang;

readonly attribute DOMString body;

readonly attribute DOMString tag;

- readonly attribute DOMString icon;

+ readonly attribute USVString icon;

[RuntimeEnabled=NotificationExperimental] readonly attribute sequence<unsigned long>? vibrate;

readonly attribute boolean silent;

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/NotificationOptions.idl » ('j') | no next file with comments »