Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 1632953002: Change the TranslateDeclined() to only count decline if the explicit_closed is set to true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac unit test breakage Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate_unittest.cc
diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8366d797f12d5aa70a0d26e6a2107f7ce0f41326
--- /dev/null
+++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc
@@ -0,0 +1,151 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/translate/core/browser/translate_ui_delegate.h"
+
+
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/macros.h"
+#include "base/strings/stringprintf.h"
+#include "build/build_config.h"
+#include "components/infobars/core/infobar.h"
+#include "components/pref_registry/testing_pref_service_syncable.h"
+#include "components/translate/core/browser/mock_translate_driver.h"
+#include "components/translate/core/browser/translate_client.h"
+#include "components/translate/core/browser/translate_infobar_delegate.h"
+#include "components/translate/core/browser/translate_manager.h"
+#include "components/translate/core/browser/translate_prefs.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+using testing::Return;
+using testing::Test;
+using translate::testing::MockTranslateDriver;
+
+
+namespace translate {
+
+#if defined(OS_CHROMEOS)
+const char* preferred_languages_prefs =
+ "settings.language.preferred_languages";
+#else
+const char* preferred_languages_prefs = NULL;
+#endif
+
+class MockTranslateClient : public TranslateClient {
+ public:
+ MockTranslateClient(
+ TranslateDriver* driver,
+ PrefService* prefs)
+ : driver_(driver),
+ prefs_(prefs) {
+ }
+
+ TranslateDriver* GetTranslateDriver() { return driver_; }
+ PrefService* GetPrefs() { return prefs_; }
+
+ scoped_ptr<TranslatePrefs> GetTranslatePrefs() {
+ return make_scoped_ptr(
+ new TranslatePrefs(
+ prefs_,
+ "intl.accept_languages",
+ preferred_languages_prefs));
+ }
+
+ MOCK_METHOD0(GetTranslateAcceptLanguages, TranslateAcceptLanguages*());
+ MOCK_CONST_METHOD0(GetInfobarIconID, int());
+
+ MOCK_CONST_METHOD1(CreateInfoBarMock,
+ infobars::InfoBar*(TranslateInfoBarDelegate*));
+ scoped_ptr<infobars::InfoBar> CreateInfoBar(
+ scoped_ptr<TranslateInfoBarDelegate> delegate) const {
+ return scoped_ptr<infobars::InfoBar>(
+ CreateInfoBarMock(std::move(delegate).get()));
+ }
+
+ MOCK_METHOD5(ShowTranslateUI, void(translate::TranslateStep,
+ const std::string&,
+ const std::string&,
+ TranslateErrors::Type,
+ bool));
+ MOCK_METHOD1(IsTranslatableURL, bool(const GURL&));
+ MOCK_METHOD1(ShowReportLanguageDetectionErrorUI, void(const GURL&));
+
+ private:
+ TranslateDriver* driver_;
+ PrefService* prefs_;
+};
+
+class TranslateUIDelegateTest : public ::testing::Test {
+ public:
+ TranslateUIDelegateTest() : ::testing::Test() {}
+
+ void SetUp() override {
+ pref_service_.reset(new user_prefs::TestingPrefServiceSyncable());
+ TranslatePrefs::RegisterProfilePrefs(pref_service_->registry());
+
+ client_.reset(new MockTranslateClient(
+ &driver_,
+ pref_service_.get()));
+
+ manager_.reset(new TranslateManager(client_.get(), "hi"));
+ manager_->GetLanguageState().set_translation_declined(false);
+
+ delegate_.reset(new TranslateUIDelegate(
+ manager_->GetWeakPtr(), "ar", "fr"));
+
+ ASSERT_FALSE(client_->GetTranslatePrefs()->IsTooOftenDenied("ar"));
+ }
+
+
+ MockTranslateDriver driver_;
+ scoped_ptr<MockTranslateClient> client_;
+ scoped_ptr<user_prefs::TestingPrefServiceSyncable> pref_service_;
+ scoped_ptr<TranslateManager> manager_;
+ scoped_ptr<TranslateUIDelegate> delegate_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TranslateUIDelegateTest);
+};
+
+
+TEST_F(TranslateUIDelegateTest, CheckDeclinedFalse) {
+ scoped_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
+ for (int i = 0; i < 10; i++) {
+ prefs->IncrementTranslationAcceptedCount("ar");
+ }
+ prefs->IncrementTranslationDeniedCount("ar");
+ int accepted_count = prefs->GetTranslationAcceptedCount("ar");
+ int denied_count = prefs->GetTranslationDeniedCount("ar");
+
+ delegate_->TranslationDeclined(false);
+
+ EXPECT_EQ(accepted_count, prefs->GetTranslationAcceptedCount("ar"));
+ EXPECT_EQ(denied_count, prefs->GetTranslationDeniedCount("ar"));
+ EXPECT_FALSE(prefs->IsTooOftenDenied("ar"));
+ EXPECT_FALSE(manager_->GetLanguageState().translation_declined());
+}
+
+TEST_F(TranslateUIDelegateTest, CheckDeclinedTrue) {
+ scoped_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
+ for (int i = 0; i < 10; i++) {
+ prefs->IncrementTranslationAcceptedCount("ar");
+ }
+ prefs->IncrementTranslationDeniedCount("ar");
+ int denied_count = prefs->GetTranslationDeniedCount("ar");
+
+ delegate_->TranslationDeclined(true);
+
+ EXPECT_EQ(0, prefs->GetTranslationAcceptedCount("ar"));
+ EXPECT_EQ(denied_count + 1, prefs->GetTranslationDeniedCount("ar"));
+ EXPECT_TRUE(manager_->GetLanguageState().translation_declined());
+}
+
+// TODO(ftang) Currently this file only test TranslationDeclined(), we
+// need to add the test for other functions soon to increase the test
+// coverage.
+
+} // namespace translate

Powered by Google App Engine
This is Rietveld 408576698