components/translate/core/browser/translate_infobar_delegate.cc - Issue 1632953002: Change the TranslateDeclined() to only count decline if the explicit_closed is set to true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_infobar_delegate.cc

Issue 1632953002: Change the TranslateDeclined() to only count decline if the explicit_closed is set to true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac unit test breakage Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/core/browser/BUILD.gn ('K') | « components/translate/core/browser/mock_translate_driver.cc ('k') | components/translate/core/browser/translate_ui_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_infobar_delegate.cc

diff --git a/components/translate/core/browser/translate_infobar_delegate.cc b/components/translate/core/browser/translate_infobar_delegate.cc

index 9f428a73b7cc8e121009562432e7b8ebcf2a10b1..874330cd99e5c689b7ae5aa91f8eafc4de7599f0 100644

--- a/components/translate/core/browser/translate_infobar_delegate.cc

+++ b/components/translate/core/browser/translate_infobar_delegate.cc

@@ -141,7 +141,7 @@ void TranslateInfoBarDelegate::ReportLanguageDetectionError() {

}

void TranslateInfoBarDelegate::TranslationDeclined() {

- ui_delegate_.TranslationDeclined(false);

+ ui_delegate_.TranslationDeclined(true);

}

bool TranslateInfoBarDelegate::IsTranslatableLanguageByPrefs() {