Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Unified Diff: components/translate/core/browser/language_state_unittest.cc

Issue 1632953002: Change the TranslateDeclined() to only count decline if the explicit_closed is set to true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac unit test breakage Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/language_state_unittest.cc
diff --git a/components/translate/core/browser/language_state_unittest.cc b/components/translate/core/browser/language_state_unittest.cc
index 2116e96de90a10c390a1a2b5a08eb9318aeb7dcf..d58377389603d76852b6b199fb7aed5f2d3bfb42 100644
--- a/components/translate/core/browser/language_state_unittest.cc
+++ b/components/translate/core/browser/language_state_unittest.cc
@@ -7,77 +7,13 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "components/translate/core/browser/language_state.h"
-#include "components/translate/core/browser/translate_driver.h"
+#include "components/translate/core/browser/mock_translate_driver.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
-namespace translate {
-
-namespace {
-
-const std::string kHtmlMimeType = "text/html";
-
-class MockTranslateDriver : public TranslateDriver {
- public:
- MockTranslateDriver()
- : on_is_page_translated_changed_called_(false),
- on_translate_enabled_changed_called_(false),
- language_state_(this) {
- }
-
- void Reset() {
- on_is_page_translated_changed_called_ = false;
- on_translate_enabled_changed_called_ = false;
- }
-
- virtual ~MockTranslateDriver() {}
-
- void OnIsPageTranslatedChanged() override {
- on_is_page_translated_changed_called_ = true;
- }
-
- void OnTranslateEnabledChanged() override {
- on_translate_enabled_changed_called_ = true;
- }
-
- bool IsLinkNavigation() override { return false; }
-
- void TranslatePage(int page_seq_no,
- const std::string& translate_script,
- const std::string& source_lang,
- const std::string& target_lang) override {}
-
- void RevertTranslation(int page_seq_no) override {}
+using translate::testing::MockTranslateDriver;
- bool IsOffTheRecord() override { return false; }
-
- const std::string& GetContentsMimeType() override { return kHtmlMimeType; }
-
- const GURL& GetLastCommittedURL() override { return GURL::EmptyGURL(); }
-
- const GURL& GetVisibleURL() override { return GURL::EmptyGURL(); }
-
- bool HasCurrentPage() override { return true; }
-
- void OpenUrlInNewTab(const GURL& url) override {}
-
- bool on_is_page_translated_changed_called() const {
- return on_is_page_translated_changed_called_;
- }
-
- bool on_translate_enabled_changed_called() const {
- return on_translate_enabled_changed_called_;
- }
-
- private:
- bool on_is_page_translated_changed_called_;
- bool on_translate_enabled_changed_called_;
- LanguageState language_state_;
-
- DISALLOW_COPY_AND_ASSIGN(MockTranslateDriver);
-};
-
-} // namespace
+namespace translate {
TEST(LanguageStateTest, IsPageTranslated) {
scoped_ptr<MockTranslateDriver> driver(

Powered by Google App Engine
This is Rietveld 408576698