Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: src/frames.cc

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: DCHECK in serializer Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index a57d28bde6c454562dd07e2df0ca6095a36c9940..fa5c6b1aa02b75e0c8eeda5165b5ae2381585773 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -1517,7 +1517,7 @@ Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(
Address inner_pointer) {
Heap* heap = isolate_->heap();
if (!heap->code_space()->Contains(inner_pointer) &&
- !heap->lo_space()->Contains(inner_pointer)) {
+ !heap->lo_space()->ContainsSlow(inner_pointer)) {
ulan 2016/02/09 13:36:50 We check the large space again below, so here we c
Hannes Payer (out of office) 2016/02/09 14:40:22 +1
Michael Lippautz 2016/02/09 14:50:28 Done.
Michael Lippautz 2016/02/09 14:50:28 Done.
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698