[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/frames.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/frames.h"
 
 #include <sstream>
 
 #include "src/ast/ast.h"
 #include "src/ast/scopeinfo.h"
@@ skipping 1499 matching lines @@
   Code* code = reinterpret_cast<Code*>(object);
   DCHECK(code != NULL && GcSafeCodeContains(code, inner_pointer));
   return code;
 }
 
 
 Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(
     Address inner_pointer) {
   Heap* heap = isolate_->heap();
   if (!heap->code_space()->Contains(inner_pointer) &&
-      !heap->lo_space()->Contains(inner_pointer)) {
+      !heap->lo_space()->ContainsSlow(inner_pointer)) {

[ulan, 2016/02/09 13:36:50]

We check the large space again below, so here we could avoid ContainsSlow by
moving the if statement after the large space check.

[Hannes Payer (out of office), 2016/02/09 14:40:22]

+1

[Michael Lippautz, 2016/02/09 14:50:28]

Done.

[Michael Lippautz, 2016/02/09 14:50:28]

Done.

     return nullptr;
   }
 
   // Check if the inner pointer points into a large object chunk.
   LargePage* large_page = heap->lo_space()->FindPage(inner_pointer);
   if (large_page != NULL) {
     return GcSafeCastToCode(large_page->GetObject(), inner_pointer);
   }
 
   // Iterate through the page until we reach the end or find an object starting
@@ skipping 107 matching lines @@
   for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
     StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
     list.Add(frame, zone);
   }
   return list.ToVector();
 }
 
 
 }  // namespace internal
 }  // namespace v8