Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: src/objects-inl.h

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index e064ce60569bfc63bc33b7fd943271394a164080..5791ab63c186a94a3d1ce74487d3cc2a608dc5be 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1239,11 +1239,11 @@ MaybeHandle<Object> Object::GetProperty(Isolate* isolate, Handle<Object> object,
reinterpret_cast<base::AtomicWord*>(FIELD_ADDR(p, offset)), \
reinterpret_cast<base::AtomicWord>(value));
-#define WRITE_BARRIER(heap, object, offset, value) \
- heap->incremental_marking()->RecordWrite( \
- object, HeapObject::RawField(object, offset), value); \
- if (heap->InNewSpace(value)) { \
- heap->RecordWrite(object->address(), offset); \
+#define WRITE_BARRIER(heap, object, offset, value) \
+ heap->incremental_marking()->RecordWrite( \
+ object, HeapObject::RawField(object, offset), value); \
+ if (heap->InNewSpace(value)) { \
+ heap->RecordWrite(object, offset); \
}
#define CONDITIONAL_WRITE_BARRIER(heap, object, offset, value, mode) \
@@ -1253,7 +1253,7 @@ MaybeHandle<Object> Object::GetProperty(Isolate* isolate, Handle<Object> object,
object, HeapObject::RawField(object, offset), value); \
} \
if (heap->InNewSpace(value)) { \
- heap->RecordWrite(object->address(), offset); \
+ heap->RecordWrite(object, offset); \
} \
}
@@ -2043,7 +2043,7 @@ void WeakCell::initialize(HeapObject* val) {
// mark through a weak cell and collect evacuation candidates when we process
// all weak cells.
if (heap->InNewSpace(val)) {
- heap->RecordWrite(address(), kValueOffset);
+ heap->RecordWrite(this, kValueOffset);
}
}

Powered by Google App Engine
This is Rietveld 408576698