[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/snapshot/serialize.cc

Index: src/snapshot/serialize.cc
diff --git a/src/snapshot/serialize.cc b/src/snapshot/serialize.cc
index 096576f0a0e913b7aff318a6bb576bf6e7397779..21981b31f08d4451d76ffa724649048ff21fa7f7 100644
--- a/src/snapshot/serialize.cc
+++ b/src/snapshot/serialize.cc
@@ -54,8 +54,6 @@ ExternalReferenceTable::ExternalReferenceTable(Isolate* isolate) {
       "StackGuard::address_of_real_jslimit()");
   Add(ExternalReference::new_space_start(isolate).address(),
       "Heap::NewSpaceStart()");
-  Add(ExternalReference::new_space_mask(isolate).address(),
-      "Heap::NewSpaceMask()");
   Add(ExternalReference::new_space_allocation_limit_address(isolate).address(),
       "Heap::NewSpaceAllocationLimitAddress()");
   Add(ExternalReference::new_space_allocation_top_address(isolate).address(),
@@ -1014,7 +1012,7 @@ bool Deserializer::ReadData(Object** current, Object** limit, int source_space,
     }                                                                          \
     if (emit_write_barrier && write_barrier_needed) {                          \
       Address current_address = reinterpret_cast<Address>(current);            \
-      isolate->heap()->RecordWrite(                                            \
+      isolate->heap()->RecordWriteSlow(                                        \

[Michael Lippautz, 2016/02/05 12:44:40]

I tried switching this to the fast check, which assumes that we have a valid
Object* already, but unfortunately some tests crashed.

So I assume that current_object_address could also be some off-heap address at
this point (which requires the slow version to be filtered out).  Is this the
case?

[Yang, 2016/02/05 12:54:05]

Yes I think this is the case. The deserializer is an object visitor that
iterates the heap. There we also iterate addresses that are not on the heap, for
example builtins code list.

[Michael Lippautz, 2016/02/08 18:00:38]

Actually, we are in a path where we can cast to Object*, as we've ruled out
builtins already above. I was lacking the pointer tag though, leading to misses
entries.

           current_object_address,                                              \
           static_cast<int>(current_address - current_object_address));         \
     }                                                                          \
@@ -1250,7 +1248,7 @@ bool Deserializer::ReadData(Object** current, Object** limit, int source_space,
         UnalignedCopy(current, &hot_object);
         if (write_barrier_needed && isolate->heap()->InNewSpace(hot_object)) {
           Address current_address = reinterpret_cast<Address>(current);
-          isolate->heap()->RecordWrite(
+          isolate->heap()->RecordWriteSlow(
               current_object_address,
               static_cast<int>(current_address - current_object_address));
         }