Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: src/heap/heap.h

Issue 1632913003: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index f4c8ef3f1e696fcd2f78924245b15480cbe2a46b..4dfac4faf0501a25969dc06f861675d11cffdd37 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -887,7 +887,6 @@ class Heap {
// address with the mask will result in the start address of the new space
// for all addresses in either semispace.
Address NewSpaceStart() { return new_space_.start(); }
- uintptr_t NewSpaceMask() { return new_space_.mask(); }
Address NewSpaceTop() { return new_space_.top(); }
NewSpace* new_space() { return &new_space_; }
@@ -1084,10 +1083,10 @@ class Heap {
// ===========================================================================
// Write barrier support for address[offset] = o.
- INLINE(void RecordWrite(Address address, int offset));
+ inline void RecordWriteSlow(Address address, int offset);
Hannes Payer (out of office) 2016/02/08 16:05:40 As discussed offline, this one should become Objec
Michael Lippautz 2016/02/08 18:00:38 The only remaining interface now is // Write bar
- // Write barrier support for address[start : start + len[ = o.
- INLINE(void RecordWrites(Address address, int start, int len));
+ // Write barrier support for object[offset] = o;
+ inline void RecordWrite(Object* object, int offset);
Address* store_buffer_top_address() {
return reinterpret_cast<Address*>(&roots_[kStoreBufferTopRootIndex]);
@@ -1131,10 +1130,9 @@ class Heap {
// Returns whether the object resides in new space.
inline bool InNewSpace(Object* object);
- inline bool InNewSpace(Address address);
- inline bool InNewSpacePage(Address address);
inline bool InFromSpace(Object* object);
inline bool InToSpace(Object* object);
+ inline bool InNewSpaceSlow(Address address);
Hannes Payer (out of office) 2016/02/08 16:05:40 InNewSpaceSlow seems to be not necessary anymore.
Michael Lippautz 2016/02/08 18:00:38 Unfortunately I think this one needs to stay right
Hannes Payer (out of office) 2016/02/08 21:33:51 I think you mentioned this already last week: if y
Michael Lippautz 2016/02/09 08:03:06 Done. The live object check is quite expensive (al
// Returns whether the object resides in old space.
inline bool InOldSpace(Address address);

Powered by Google App Engine
This is Rietveld 408576698