[heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods

src/arm/macro-assembler-arm.h

Index: src/arm/macro-assembler-arm.h
diff --git a/src/arm/macro-assembler-arm.h b/src/arm/macro-assembler-arm.h
index e837f9ce0f70c6efcfdc3a8eca7fd73b1a6c35e5..f1041db6b3aca2b313db6f7f001a9faf594445fe 100644
--- a/src/arm/macro-assembler-arm.h
+++ b/src/arm/macro-assembler-arm.h
@@ -220,7 +220,7 @@ class MacroAssembler: public Assembler {
   void JumpIfNotInNewSpace(Register object,
                            Register scratch,
                            Label* branch) {

[Hannes Payer (out of office), 2016/02/08 16:05:40]

I think this one should be ne and the one below eq.

[Michael Lippautz, 2016/02/08 18:00:38]

I don't think so. I think that the code is confusing though...

The code does:
  mask = IN_FROM_SPACE | IN_TO_SPACE
  TST flags, mask => does an AND, and sets Z(ero) flag according.
  Beq => jumps on Z set, which is when neither IN_FROM_SPACE or IN_TO_SPACE is
set

[Hannes Payer (out of office), 2016/02/08 21:33:51]

Acknowledged.

-    InNewSpace(object, scratch, ne, branch);
+    InNewSpace(object, scratch, eq, branch);
   }
 
   // Check if object is in new space.  Jumps if the object is in new space.
@@ -228,7 +228,7 @@ class MacroAssembler: public Assembler {
   void JumpIfInNewSpace(Register object,
                         Register scratch,
                         Label* branch) {
-    InNewSpace(object, scratch, eq, branch);
+    InNewSpace(object, scratch, ne, branch);
   }
 
   // Check if an object has a given incremental marking color.