Add a note to avoid SSLServerSocket in new code.

Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176
Committed: https://crrev.com/582222f7cac62a2e4c528655892fdb470c3fbd95
Cr-Commit-Position: refs/heads/master@{#400502}

[davidben, 2016-01-25 22:12:22]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2016-01-25 22:12:23]

Happy to tweak the text or put it elsewhere if you prefer.

[Ryan Sleevi, 2016-01-25 22:21:05]

https://codereview.chromium.org/1632913002/diff/1/net/socket/ssl_server_socket.h
File net/socket/ssl_server_socket.h (right):

https://codereview.chromium.org/1632913002/diff/1/net/socket/ssl_server_socke...
net/socket/ssl_server_socket.h:14: // This header should not be used in new
code, outside of unit tests.
That seems sort of small and hard to miss.

The header-level documentation goes before the includes (per
https://google.github.io/styleguide/cppguide.html#File_Comments )

// found in the LICENSE file.
//
// NOTE: This class is provided to support existing Chromium
// consumers; it is NOT intended for use in NEW code. In
// particular, it is explicitly NOT supported on iOS and has no
// such plans for the forseeable future. Configuring a TLS
// server correctly is a dangerous, security-sensitive activity
// with many subtle nuances, and thus care should be taken to
// discuss with //net/OWNERS before any new usages.
//
// As such, this header should be treated as an internal
// implementation detail of //net (where it's used for some
// unit test infrastructure), not as appropriate for general use.
//
// TODO(rsleevi? davidben?): See https://crbug.com/foo for more
// details.

And we should file a bug capturing our collective grumps on it :)

[Ryan Sleevi, 2016-05-16 20:57:22]

Old CL poke?

[davidben, 2016-06-10 18:17:54]

On 2016/01/25 22:21:05, Ryan Sleevi wrote:
>
https://codereview.chromium.org/1632913002/diff/1/net/socket/ssl_server_socket.h
> File net/socket/ssl_server_socket.h (right):
> 
>
https://codereview.chromium.org/1632913002/diff/1/net/socket/ssl_server_socke...
> net/socket/ssl_server_socket.h:14: // This header should not be used in new
> code, outside of unit tests.
> That seems sort of small and hard to miss.
> 
> The header-level documentation goes before the includes (per
> https://google.github.io/styleguide/cppguide.html#File_Comments )
> 
> // found in the LICENSE file.
> //
> // NOTE: This class is provided to support existing Chromium
> // consumers; it is NOT intended for use in NEW code. In
> // particular, it is explicitly NOT supported on iOS and has no
> // such plans for the forseeable future. Configuring a TLS
> // server correctly is a dangerous, security-sensitive activity
> // with many subtle nuances, and thus care should be taken to
> // discuss with //net/OWNERS before any new usages.
> //
> // As such, this header should be treated as an internal
> // implementation detail of //net (where it's used for some
> // unit test infrastructure), not as appropriate for general use.
> //
> // TODO(rsleevi? davidben?): See https://crbug.com/foo for more
> // details.
> 
> And we should file a bug capturing our collective grumps on it :)

Er, what do you want the bug to say? Like what concrete task should the bug be
about?

[Ryan Sleevi, 2016-06-16 00:28:12]

On 2016/06/10 18:17:54, davidben wrote:
> Er, what do you want the bug to say? Like what concrete task should the bug be
> about?

Well, when last we talked, it was either "Make SSL servers a first class citizen
of //net" (now that we're on BoringSSL everywhere, it's reasonable), or "Get rid
of this from //net and move it to embedders" (with all the tradeoffs that
entails)

Since that proposed comment, it's now supported on iOS (right?), and some of the
BS re: server caching can be resolved, so it's a question of "What would it take
to make this be something we'd Support(tm) in a way we don't care who uses it"

[davidben, 2016-06-17 20:08:52]

Description was changed from

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=580686
==========

to

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176
==========

[davidben, 2016-06-17 20:10:49]

Revised comment

[Ryan Sleevi, 2016-06-17 20:23:24]

lgtm

[davidben, 2016-06-17 20:51:51]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-06-17 20:52:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1632913002/20001

[commit-bot: I haz the power, 2016-06-17 21:03:27]

Description was changed from

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176
==========

to

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176
==========

[commit-bot: I haz the power, 2016-06-17 21:03:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 21:05:03]

Description was changed from

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176
==========

to

==========
Add a note to avoid SSLServerSocket in new code.

This class is not maintained as a production-quality SSL server. Add a note
that it shouldn't be used outside of tests.

BUG=621176

Committed: https://crrev.com/582222f7cac62a2e4c528655892fdb470c3fbd95
Cr-Commit-Position: refs/heads/master@{#400502}
==========

[commit-bot: I haz the power, 2016-06-17 21:05:04]

Patchset 2 (id:??) landed as
https://crrev.com/582222f7cac62a2e4c528655892fdb470c3fbd95
Cr-Commit-Position: refs/heads/master@{#400502}