Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: net/socket/ssl_server_socket.h

Issue 1632913002: Add a note to avoid SSLServerSocket in new code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SSL_SERVER_SOCKET_H_ 5 #ifndef NET_SOCKET_SSL_SERVER_SOCKET_H_
6 #define NET_SOCKET_SSL_SERVER_SOCKET_H_ 6 #define NET_SOCKET_SSL_SERVER_SOCKET_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "net/base/completion_callback.h" 9 #include "net/base/completion_callback.h"
10 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
11 #include "net/socket/ssl_socket.h" 11 #include "net/socket/ssl_socket.h"
12 #include "net/socket/stream_socket.h" 12 #include "net/socket/stream_socket.h"
13 13
14 // This header should not be used in new code, outside of unit tests.
Ryan Sleevi 2016/01/25 22:21:04 That seems sort of small and hard to miss. The he
15
14 namespace crypto { 16 namespace crypto {
15 class RSAPrivateKey; 17 class RSAPrivateKey;
16 } // namespace crypto 18 } // namespace crypto
17 19
18 namespace net { 20 namespace net {
19 21
20 struct SSLServerConfig; 22 struct SSLServerConfig;
21 class X509Certificate; 23 class X509Certificate;
22 24
23 class SSLServerSocket : public SSLSocket { 25 class SSLServerSocket : public SSLSocket {
(...skipping 29 matching lines...) Expand all
53 // returned socket. 55 // returned socket.
54 NET_EXPORT scoped_ptr<SSLServerSocket> CreateSSLServerSocket( 56 NET_EXPORT scoped_ptr<SSLServerSocket> CreateSSLServerSocket(
55 scoped_ptr<StreamSocket> socket, 57 scoped_ptr<StreamSocket> socket,
56 X509Certificate* certificate, 58 X509Certificate* certificate,
57 const crypto::RSAPrivateKey& key, 59 const crypto::RSAPrivateKey& key,
58 const SSLServerConfig& ssl_config); 60 const SSLServerConfig& ssl_config);
59 61
60 } // namespace net 62 } // namespace net
61 63
62 #endif // NET_SOCKET_SSL_SERVER_SOCKET_H_ 64 #endif // NET_SOCKET_SSL_SERVER_SOCKET_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698