Move a bunch of child-only code from content/common to content/child

Move a bunch of child-only code from content/common to content/child

Was just trying to move content/common/resource_dispatcher.{cc,h}, but that ends up needing a lot of other things to move.

TBR=jam@chromium.org

BUG=246357
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204569

[scottmg, 2013-06-04 23:26:38]

John, could you look over this before I make it even larger?

Mostly regarding whether it's OK to keep going in this vein... I don't think I
can land any smaller part unless it's OK to land checkdeps violations
temporarily.

If you have any thoughts on the "Remaining to resolve" list in the CL
description that'd be helpful too. Moving the gpu stuff around will add another
50 files to the CL.

The majority is just moving. content/common/debug_util.{cc,h} was split out of
child_process.{cc,h} as it's used in the browser.

[scottmg, 2013-06-04 23:39:17]

On 2013/06/04 23:26:38, scottmg wrote:
> John, could you look over this before I make it even larger?
> 
> Mostly regarding whether it's OK to keep going in this vein... I don't think I
> can land any smaller part unless it's OK to land checkdeps violations
> temporarily.
> 
> If you have any thoughts on the "Remaining to resolve" list in the CL
> description that'd be helpful too. Moving the gpu stuff around will add
another
> 50 files to the CL.
> 
> The majority is just moving. content/common/debug_util.{cc,h} was split out of
> child_process.{cc,h} as it's used in the browser.

Ignore all that. I think all is well after resolving the single-process cases
(which I added DEPS entries for).

Please review at your leisure.

[scottmg, 2013-06-04 23:54:14]

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:12: #include
"content/child/child_thread.h"
Actually, I guess this include is wrong, but as far as I can tell this code is
child only. (?)

[jam, 2013-06-05 16:54:58]

btw totally acceptable to add temporary includes so that your changes don't
balloon :)

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:12: #include
"content/child/child_thread.h"
On 2013/06/04 23:54:14, scottmg wrote:
> Actually, I guess this include is wrong, but as far as I can tell this code is
> child only. (?)

why do you say the include is wrong? it appears that this code is run in child
processes, so i assume you'll move this to content/child later?

https://codereview.chromium.org/16328003/diff/28001/content/browser/browser_m...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/16328003/diff/28001/content/browser/browser_m...
content/browser/browser_main_runner.cc:53: WaitForDebugger("Browser");
actually, you can take out this whole section. this code got added for pyauto
which has been deprecated for a long time, and since devs don't use it, no need
to support this debugging option.

https://codereview.chromium.org/16328003/diff/28001/content/child/DEPS
File content/child/DEPS (right):

https://codereview.chromium.org/16328003/diff/28001/content/child/DEPS#newcode2
content/child/DEPS:2: "+components/tracing",
now you can take this out of content/common/DEPS

[scottmg, 2013-06-05 17:19:26]

thanks, i'll try to make the next one(s) smaller with some carefully chosen
temporary DEPS instead.

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:12: #include
"content/child/child_thread.h"
On 2013/06/05 16:54:58, jam wrote:
> On 2013/06/04 23:54:14, scottmg wrote:
> > Actually, I guess this include is wrong, but as far as I can tell this code
is
> > child only. (?)
> 
> why do you say the include is wrong? it appears that this code is run in child
> processes, so i assume you'll move this to content/child later? 

Yah, that's what I meant (it's going child->common right now). It looks like
most/all of common/gpu could go to child/gpu?

https://codereview.chromium.org/16328003/diff/28001/content/browser/browser_m...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/16328003/diff/28001/content/browser/browser_m...
content/browser/browser_main_runner.cc:53: WaitForDebugger("Browser");
On 2013/06/05 16:54:58, jam wrote:
> actually, you can take out this whole section. this code got added for pyauto
> which has been deprecated for a long time, and since devs don't use it, no
need
> to support this debugging option.

Done.

https://codereview.chromium.org/16328003/diff/28001/content/child/DEPS
File content/child/DEPS (right):

https://codereview.chromium.org/16328003/diff/28001/content/child/DEPS#newcode2
content/child/DEPS:2: "+components/tracing",
On 2013/06/05 16:54:58, jam wrote:
> now you can take this out of content/common/DEPS

Done.

[jam, 2013-06-06 16:07:29]

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
File content/common/gpu/media/vaapi_video_decode_accelerator.cc (right):

https://codereview.chromium.org/16328003/diff/24001/content/common/gpu/media/...
content/common/gpu/media/vaapi_video_decode_accelerator.cc:12: #include
"content/child/child_thread.h"
On 2013/06/05 17:19:27, scottmg wrote:
> On 2013/06/05 16:54:58, jam wrote:
> > On 2013/06/04 23:54:14, scottmg wrote:
> > > Actually, I guess this include is wrong, but as far as I can tell this
code
> is
> > > child only. (?)
> > 
> > why do you say the include is wrong? it appears that this code is run in
child
> > processes, so i assume you'll move this to content/child later? 
> 
> Yah, that's what I meant (it's going child->common right now). It looks like
> most/all of common/gpu could go to child/gpu?

theoretically, yes. there are just a bunch of includes now

https://codereview.chromium.org/16328003/diff/32001/content/common/debug_util.h
File content/common/debug_util.h (right):

https://codereview.chromium.org/16328003/diff/32001/content/common/debug_util...
content/common/debug_util.h:1: // Copyright 2013 The Chromium Authors. All
rights reserved.
there's no need to split this file out now anymore right?

[scottmg, 2013-06-06 16:26:47]

(sorry, some rebasing changes. 11->12 just puts WaitForDebugger back into
ChildProcess)

https://codereview.chromium.org/16328003/diff/32001/content/common/debug_util.h
File content/common/debug_util.h (right):

https://codereview.chromium.org/16328003/diff/32001/content/common/debug_util...
content/common/debug_util.h:1: // Copyright 2013 The Chromium Authors. All
rights reserved.
On 2013/06/06 16:07:30, jam wrote:
> there's no need to split this file out now anymore right?

Done.

[jam, 2013-06-06 16:29:44]

lgtm

[scottmg, 2013-06-06 16:38:38]

tbr nduca, moving components/tracing DEPS from content/common/DEPS to
content/child/DEPS.

[scottmg, 2013-06-06 20:08:10]

Committed patchset #14 manually as r204569 (presubmit successful).