Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1632793002: Add missing null check to AVDA deferred rendering shutdown path. (Closed)

Created:
4 years, 11 months ago by liberato (no reviews please)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing null check to AVDA deferred rendering shutdown path. If the GVD tears down AVDA before Initialize is called on the strategy, usually due to an unsupported format, then the deferred rendering backing strategy would access |shared_state_| before it was initialized. It now detects this, and skips all cleanup if Initialize wasn't ever called. BUG=580335 Committed: https://crrev.com/426b349ca21fe6e023caf76f6a92deba79fd9525 Cr-Commit-Position: refs/heads/master@{#371324}

Patch Set 1 #

Patch Set 2 : ran cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/common/gpu/media/android_deferred_rendering_backing_strategy.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
liberato (no reviews please)
4 years, 11 months ago (2016-01-25 18:57:37 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 11 months ago (2016-01-25 18:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632793002/20001
4 years, 11 months ago (2016-01-25 21:34:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 21:47:04 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 21:49:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/426b349ca21fe6e023caf76f6a92deba79fd9525
Cr-Commit-Position: refs/heads/master@{#371324}

Powered by Google App Engine
This is Rietveld 408576698