Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1632643002: MIPS64: Fix 'Array length reduction should throw in strict mode if it can't delete an element.' (Closed)

Created:
4 years, 11 months ago by akos.palfi.imgtec
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Array length reduction should throw in strict mode if it can't delete an element.' BUG= Committed: https://crrev.com/b4b511000957b602df463799d0be7e492aad36bb Cr-Commit-Position: refs/heads/master@{#33493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
akos.palfi.imgtec
PTAL.
4 years, 11 months ago (2016-01-25 14:46:46 UTC) #2
Igor Sheludko
LGTM. Thanks for catching this!
4 years, 11 months ago (2016-01-25 14:59:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632643002/1
4 years, 11 months ago (2016-01-25 15:01:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 15:25:26 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 15:26:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4b511000957b602df463799d0be7e492aad36bb
Cr-Commit-Position: refs/heads/master@{#33493}

Powered by Google App Engine
This is Rietveld 408576698