Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 1632643002: MIPS64: Fix 'Array length reduction should throw in strict mode if it can't delete an element.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == 2); 595 STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == 2);
596 STATIC_ASSERT(PropertyCallbackArguments::kReturnValueDefaultValueIndex == 3); 596 STATIC_ASSERT(PropertyCallbackArguments::kReturnValueDefaultValueIndex == 3);
597 STATIC_ASSERT(PropertyCallbackArguments::kReturnValueOffset == 4); 597 STATIC_ASSERT(PropertyCallbackArguments::kReturnValueOffset == 4);
598 STATIC_ASSERT(PropertyCallbackArguments::kDataIndex == 5); 598 STATIC_ASSERT(PropertyCallbackArguments::kDataIndex == 5);
599 STATIC_ASSERT(PropertyCallbackArguments::kThisIndex == 6); 599 STATIC_ASSERT(PropertyCallbackArguments::kThisIndex == 6);
600 STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 7); 600 STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 7);
601 601
602 // Here and below +1 is for name() pushed after the args_ array. 602 // Here and below +1 is for name() pushed after the args_ array.
603 typedef PropertyCallbackArguments PCA; 603 typedef PropertyCallbackArguments PCA;
604 __ Dsubu(sp, sp, (PCA::kArgsLength + 1) * kPointerSize); 604 __ Dsubu(sp, sp, (PCA::kArgsLength + 1) * kPointerSize);
605 __ sw(receiver(), MemOperand(sp, (PCA::kThisIndex + 1) * kPointerSize)); 605 __ sd(receiver(), MemOperand(sp, (PCA::kThisIndex + 1) * kPointerSize));
606 Handle<Object> data(callback->data(), isolate()); 606 Handle<Object> data(callback->data(), isolate());
607 if (data->IsUndefined() || data->IsSmi()) { 607 if (data->IsUndefined() || data->IsSmi()) {
608 __ li(scratch2(), data); 608 __ li(scratch2(), data);
609 } else { 609 } else {
610 Handle<WeakCell> cell = 610 Handle<WeakCell> cell =
611 isolate()->factory()->NewWeakCell(Handle<HeapObject>::cast(data)); 611 isolate()->factory()->NewWeakCell(Handle<HeapObject>::cast(data));
612 // The callback is alive if this instruction is executed, 612 // The callback is alive if this instruction is executed,
613 // so the weak cell is not cleared and points to data. 613 // so the weak cell is not cleared and points to data.
614 __ GetWeakValue(scratch2(), cell); 614 __ GetWeakValue(scratch2(), cell);
615 } 615 }
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 // Return the generated code. 791 // Return the generated code.
792 return GetCode(kind(), Code::NORMAL, name); 792 return GetCode(kind(), Code::NORMAL, name);
793 } 793 }
794 794
795 795
796 #undef __ 796 #undef __
797 } // namespace internal 797 } // namespace internal
798 } // namespace v8 798 } // namespace v8
799 799
800 #endif // V8_TARGET_ARCH_MIPS64 800 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698