Issue 163243002: Disable Mac AVFoundation for WebRTC browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163243002: Disable Mac AVFoundation for WebRTC browser tests. (Closed)

Created:
6 years, 10 months ago by mcasas

Modified:
6 years, 10 months ago

Reviewers:
phoglund1, phoglund_chromium, tommi (sloooow) - chröme

CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable Mac AVFoundation for WebRTC browser tests. WebRTC browser tests is based on Manycam virtual capture device, but this does not work with AVFoundation, see bug. Termporarily, disable AVFoundation for those tests, hence using QTKit capture Framework. BUG=327618, 288562 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251049

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/media/chrome_webrtc_browsertest.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

On 2014/02/13 10:52:27, phoglund1 wrote: > Yeah, that should be all of them. lgtm From ...

6 years, 10 months ago (2014-02-13 10:52:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/163243002/1

6 years, 10 months ago (2014-02-13 10:54:06 UTC) #6

Message was sent while issue was closed.

Change committed as 251049

Expand Messages | Collapse Messages