Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 163243002: Disable Mac AVFoundation for WebRTC browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/media/chrome_webrtc_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/environment.h" 5 #include "base/environment.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/process/launch.h" 8 #include "base/process/launch.h"
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 DetectErrorsInJavaScript(); // Look for errors in our rather complex js. 105 DetectErrorsInJavaScript(); // Look for errors in our rather complex js.
106 } 106 }
107 107
108 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { 108 virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
109 // This test expects real device handling and requires a real webcam / audio 109 // This test expects real device handling and requires a real webcam / audio
110 // device; it will not work with fake devices. 110 // device; it will not work with fake devices.
111 EXPECT_FALSE( 111 EXPECT_FALSE(
112 command_line->HasSwitch(switches::kUseFakeDeviceForMediaStream)) 112 command_line->HasSwitch(switches::kUseFakeDeviceForMediaStream))
113 << "You cannot run this test with fake devices."; 113 << "You cannot run this test with fake devices.";
114 114
115 #if defined(OS_MACOSX)
116 // TODO(mcasas): Remove this switch when ManyCam virtual video capture
117 // device starts supporting AVFoundation, see http://crbug.com/327618.
118 command_line->AppendSwitch(switches::kDisableAVFoundation);
119 #endif
120
115 // The video playback will not work without a GPU, so force its use here. 121 // The video playback will not work without a GPU, so force its use here.
116 command_line->AppendSwitch(switches::kUseGpuInTests); 122 command_line->AppendSwitch(switches::kUseGpuInTests);
117 } 123 }
118 124
119 bool HasAllRequiredResources() { 125 bool HasAllRequiredResources() {
120 if (!base::PathExists(GetWorkingDir())) { 126 if (!base::PathExists(GetWorkingDir())) {
121 LOG(ERROR) << "Cannot find the working directory for the reference video " 127 LOG(ERROR) << "Cannot find the working directory for the reference video "
122 "and the temporary files:" << GetWorkingDir().value(); 128 "and the temporary files:" << GetWorkingDir().value();
123 return false; 129 return false;
124 } 130 }
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 373
368 RunARGBtoI420Converter( 374 RunARGBtoI420Converter(
369 kVgaWidth, kVgaHeight, GetWorkingDir().Append(kCapturedYuvFileName)); 375 kVgaWidth, kVgaHeight, GetWorkingDir().Append(kCapturedYuvFileName));
370 ASSERT_TRUE( 376 ASSERT_TRUE(
371 CompareVideosAndPrintResult(kVgaWidth, 377 CompareVideosAndPrintResult(kVgaWidth,
372 kVgaHeight, 378 kVgaHeight,
373 GetWorkingDir().Append(kCapturedYuvFileName), 379 GetWorkingDir().Append(kCapturedYuvFileName),
374 GetWorkingDir().Append(kReferenceYuvFileName), 380 GetWorkingDir().Append(kReferenceYuvFileName),
375 GetWorkingDir().Append(kStatsFileName))); 381 GetWorkingDir().Append(kStatsFileName)));
376 } 382 }
OLDNEW
« no previous file with comments | « chrome/browser/media/chrome_webrtc_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698