Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5236)

Unified Diff: chromecast/browser/BUILD.gn

Issue 1632323002: [chromecast] Statically link libcast_media_default for browsertest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/BUILD.gn
diff --git a/chromecast/browser/BUILD.gn b/chromecast/browser/BUILD.gn
index 1e3a7a17ebd293042bb0eb6fe448e8145feb76f3..c3524a7265c0e557e3e598417363572c8e7c2ef5 100644
--- a/chromecast/browser/BUILD.gn
+++ b/chromecast/browser/BUILD.gn
@@ -180,4 +180,10 @@ test("cast_shell_browser_test") {
if (chromecast_branding != "public") {
deps += [ "//chromecast/internal:cast_shell_internal" ]
}
+
+ if (chromecast_branding == "public") {
slan 2016/01/26 20:50:34 nit: this could be } else {
alokp 2016/01/26 20:52:32 but you have a TODO there. And I have bug to get r
+ # Link default libcast_media_1.0 statically not to link dummy one
+ # dynamically for public unittests.
+ deps += [ "//chromecast/media/base:libcast_media_1.0_default_core" ]
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698