Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: chromecast/browser/BUILD.gn

Issue 1632323002: [chromecast] Statically link libcast_media_default for browsertest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chromecast/chromecast.gni") 5 import("//chromecast/chromecast.gni")
6 import("//media/media_options.gni") 6 import("//media/media_options.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 9
10 source_set("browser") { 10 source_set("browser") {
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 "//content/test:test_support", 173 "//content/test:test_support",
174 "//media/base:test_support", 174 "//media/base:test_support",
175 "//testing/gtest", 175 "//testing/gtest",
176 "//url", 176 "//url",
177 ] 177 ]
178 178
179 # TODO(slan): Find a better way to do this. 179 # TODO(slan): Find a better way to do this.
180 if (chromecast_branding != "public") { 180 if (chromecast_branding != "public") {
181 deps += [ "//chromecast/internal:cast_shell_internal" ] 181 deps += [ "//chromecast/internal:cast_shell_internal" ]
182 } 182 }
183
184 if (chromecast_branding == "public") {
slan 2016/01/26 20:50:34 nit: this could be } else {
alokp 2016/01/26 20:52:32 but you have a TODO there. And I have bug to get r
185 # Link default libcast_media_1.0 statically not to link dummy one
186 # dynamically for public unittests.
187 deps += [ "//chromecast/media/base:libcast_media_1.0_default_core" ]
188 }
183 } 189 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698