[chromecast] Statically link libcast_media_default for browsertest.

[chromecast] Statically link libcast_media_default for browsertest.

BUG=577403
Committed: https://crrev.com/061f6ef7edeba4b897d5183f55179bc7ef96ce78
Cr-Commit-Position: refs/heads/master@{#371608}

[alokp, 2016-01-26 20:48:40]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org, slan@chromium.org

[slan, 2016-01-26 20:49:56]

lgtm

[slan, 2016-01-26 20:50:34]

https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn
File chromecast/browser/BUILD.gn (right):

https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn...
chromecast/browser/BUILD.gn:184: if (chromecast_branding == "public") {
nit: this could be 
} else {

[alokp, 2016-01-26 20:52:32]

https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn
File chromecast/browser/BUILD.gn (right):

https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn...
chromecast/browser/BUILD.gn:184: if (chromecast_branding == "public") {
On 2016/01/26 20:50:34, slan wrote:
> nit: this could be 
> } else {

but you have a TODO there. And I have bug to get rid of this too:
crbug.com/581453 :)

[slan, 2016-01-26 20:53:11]

sgtm

On Tue, Jan 26, 2016 at 12:52 PM, <alokp@chromium.org> wrote:

>
>
> https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn
> File chromecast/browser/BUILD.gn (right):
>
>
>
https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn...
> chromecast/browser/BUILD.gn:184: if (chromecast_branding == "public") {
> On 2016/01/26 20:50:34, slan wrote:
>
>> nit: this could be
>> } else {
>>
>
> but you have a TODO there. And I have bug to get rid of this too:
> crbug.com/581453 :)
>
> https://codereview.chromium.org/1632323002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[halliwell, 2016-01-26 21:06:39]

On 2016/01/26 20:53:11, slan wrote:
> sgtm
> 
> On Tue, Jan 26, 2016 at 12:52 PM, <mailto:alokp@chromium.org> wrote:
> 
> >
> >
> >
https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn
> > File chromecast/browser/BUILD.gn (right):
> >
> >
> >
>
https://codereview.chromium.org/1632323002/diff/1/chromecast/browser/BUILD.gn...
> > chromecast/browser/BUILD.gn:184: if (chromecast_branding == "public") {
> > On 2016/01/26 20:50:34, slan wrote:
> >
> >> nit: this could be
> >> } else {
> >>
> >
> > but you have a TODO there. And I have bug to get rid of this too:
> > crbug.com/581453 :)
> >
> > https://codereview.chromium.org/1632323002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

lgtm

[alokp, 2016-01-26 21:07:07]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2016-01-26 21:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1632323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1632323002/1

[commit-bot: I haz the power, 2016-01-26 21:45:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 21:46:41]

Description was changed from

==========
[chromecast] Statically link libcast_media_default for browsertest.

BUG=577403
==========

to

==========
[chromecast] Statically link libcast_media_default for browsertest.

BUG=577403

Committed: https://crrev.com/061f6ef7edeba4b897d5183f55179bc7ef96ce78
Cr-Commit-Position: refs/heads/master@{#371608}
==========

[commit-bot: I haz the power, 2016-01-26 21:46:41]

Patchset 1 (id:??) landed as
https://crrev.com/061f6ef7edeba4b897d5183f55179bc7ef96ce78
Cr-Commit-Position: refs/heads/master@{#371608}