Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1632123004: Remove opaque-frame-only code to reduce top resize border size by 1 px. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove opaque-frame-only code to reduce top resize border size by 1 px. The stated goal of this was to make dragging the window easier (viz., by increasing the size of drag area atop the window by 1 px). However, this changed the area size from 12 px. high to 13 px., which seems like a rather trivial "improvement" to make, and we've gotten by without such a change in the glass frame (which uses 12 px.) for years. Furthermore, the top resize border was changed from 4 px. to 3 px., which seems honestly pretty small, especially when the glass frame will end up using Windows' default 8 px. or whatever. So remove this code to make the two frames match up better. BUG=none TEST=none Committed: https://crrev.com/bfe14dd182c7c660eb27265dfeec462768af2422 Cr-Commit-Position: refs/heads/master@{#371675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
4 years, 11 months ago (2016-01-26 20:04:50 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-26 23:26:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632123004/1
4 years, 11 months ago (2016-01-26 23:37:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/107239)
4 years, 11 months ago (2016-01-27 00:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632123004/1
4 years, 11 months ago (2016-01-27 00:43:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 01:26:13 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 01:27:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfe14dd182c7c660eb27265dfeec462768af2422
Cr-Commit-Position: refs/heads/master@{#371675}

Powered by Google App Engine
This is Rietveld 408576698