Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

Issue 1632123004: Remove opaque-frame-only code to reduce top resize border size by 1 px. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/ui/view_ids.h" 10 #include "chrome/browser/ui/view_ids.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 int pushed_image_id, 113 int pushed_image_id,
114 int mask_image_id, 114 int mask_image_id,
115 int accessibility_string_id, 115 int accessibility_string_id,
116 ViewID view_id); 116 ViewID view_id);
117 117
118 // Returns the thickness of the border that makes up the window frame edges. 118 // Returns the thickness of the border that makes up the window frame edges.
119 // This does not include any client edge. If |restored| is true, this is 119 // This does not include any client edge. If |restored| is true, this is
120 // calculated as if the window was restored, regardless of its current state. 120 // calculated as if the window was restored, regardless of its current state.
121 int FrameBorderThickness(bool restored) const; 121 int FrameBorderThickness(bool restored) const;
122 122
123 // Returns the height of the top resize area. This is smaller than the frame
124 // border height in order to increase the window draggable area.
125 int TopResizeHeight() const;
126
127 // Returns true if the specified point is within the avatar menu buttons. 123 // Returns true if the specified point is within the avatar menu buttons.
128 bool IsWithinAvatarMenuButtons(const gfx::Point& point) const; 124 bool IsWithinAvatarMenuButtons(const gfx::Point& point) const;
129 125
130 // Returns the thickness of the entire nonclient left, right, and bottom 126 // Returns the thickness of the entire nonclient left, right, and bottom
131 // borders, including both the window frame and any client edge. 127 // borders, including both the window frame and any client edge.
132 int NonClientBorderThickness() const; 128 int NonClientBorderThickness() const;
133 129
134 // Returns the bounds of the titlebar icon (or where the icon would be if 130 // Returns the bounds of the titlebar icon (or where the icon would be if
135 // there was one). 131 // there was one).
136 gfx::Rect IconBounds() const; 132 gfx::Rect IconBounds() const;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 // Background painter for the window frame. 164 // Background painter for the window frame.
169 scoped_ptr<views::FrameBackground> frame_background_; 165 scoped_ptr<views::FrameBackground> frame_background_;
170 166
171 // Observer that handles platform dependent configuration. 167 // Observer that handles platform dependent configuration.
172 scoped_ptr<OpaqueBrowserFrameViewPlatformSpecific> platform_observer_; 168 scoped_ptr<OpaqueBrowserFrameViewPlatformSpecific> platform_observer_;
173 169
174 DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameView); 170 DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameView);
175 }; 171 };
176 172
177 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 173 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698