Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1632113004: ServiceWorker: Add initial implementation of ExtendableMessageEvent behind a flag (Closed)

Created:
4 years, 11 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
falken, Mike West
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, jsbell+serviceworker_chromium.org, blink-reviews, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Add initial implementation of ExtendableMessageEvent behind a flag This patch adds interfaces of ExtendableMessageEvent and roughly wires it up among renderer and browser processes behind a flag. This patch does not change the existing ServiceWorker.postMessage() mechanism, that is, regular MessageEvent is still be dispatched for ServiceWorker. Attributes of the event are not supported yet. Subsequent patches will implement them with layout tests. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#extendablemessage-event-section Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fUPpDcnOi64 BUG=543198 Committed: https://crrev.com/75945ef4d5ee116237eae2069c801fda32975b85 Cr-Commit-Position: refs/heads/master@{#373148}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address falken's comments #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : change the event name from 'extendablemessage' to 'message' #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -15 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 2 chunks +22 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 3 4 2 chunks +31 lines, -0 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 3 4 5 6 chunks +25 lines, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 3 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 4 5 3 chunks +22 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 5 chunks +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEventInit.idl View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 2 3 4 5 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 44 (28 generated)
nhiroki
PTAL, thanks!
4 years, 10 months ago (2016-01-29 05:47:44 UTC) #20
falken
lgtm https://codereview.chromium.org/1632113004/diff/200001/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h File third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/1632113004/diff/200001/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h#newcode113 third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:113: virtual void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult result) {} nit: ...
4 years, 10 months ago (2016-01-29 09:47:52 UTC) #21
nhiroki
Thank you! https://codereview.chromium.org/1632113004/diff/200001/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h File third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h (right): https://codereview.chromium.org/1632113004/diff/200001/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h#newcode113 third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h:113: virtual void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult result) {} ...
4 years, 10 months ago (2016-02-01 02:05:28 UTC) #22
nhiroki
+mkwst@, could you review following files as an OWNER? content/common/service_worker/service_worker_messages.h third_party/WebKit/Source/core/events/EventTypeNames.in third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in third_party/WebKit/Source/web/* Thanks.
4 years, 10 months ago (2016-02-01 02:16:55 UTC) #24
nhiroki
falken@, I slightly changed this patch after you reviewed. Can you take another look? Thanks! ...
4 years, 10 months ago (2016-02-02 05:53:38 UTC) #25
falken
still lgtm
4 years, 10 months ago (2016-02-02 06:02:09 UTC) #26
nhiroki
On 2016/02/02 06:02:09, falken wrote: > still lgtm Thank you!
4 years, 10 months ago (2016-02-02 06:06:40 UTC) #27
nhiroki
mkwst@: fyi, I removed changes for EventTypeNames.in from this CL. - content/common/service_worker/service_worker_messages.h - third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in - ...
4 years, 10 months ago (2016-02-02 06:13:15 UTC) #28
Mike West
On 2016/02/02 at 06:13:15, nhiroki wrote: > mkwst@: fyi, I removed changes for EventTypeNames.in from ...
4 years, 10 months ago (2016-02-02 15:28:54 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632113004/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632113004/280001
4 years, 10 months ago (2016-02-02 22:45:12 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/17215) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-02 22:55:39 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632113004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632113004/300001
4 years, 10 months ago (2016-02-03 00:56:57 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/16518) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-03 01:11:04 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632113004/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632113004/300001
4 years, 10 months ago (2016-02-03 01:46:20 UTC) #40
commit-bot: I haz the power
Committed patchset #6 (id:300001)
4 years, 10 months ago (2016-02-03 03:08:40 UTC) #42
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 03:09:33 UTC) #44
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/75945ef4d5ee116237eae2069c801fda32975b85
Cr-Commit-Position: refs/heads/master@{#373148}

Powered by Google App Engine
This is Rietveld 408576698