content/browser/service_worker/service_worker_metrics.cc - Issue 1632113004: ServiceWorker: Add initial implementation of ExtendableMessageEvent behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1632113004: ServiceWorker: Add initial implementation of ExtendableMessageEvent behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.cc

diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc

index f32a0916099756054dcdcf6bb0973e3eee108550..c1d3699ddaf3580577fadf5723d339c8b38eb4f3 100644

--- a/content/browser/service_worker/service_worker_metrics.cc

+++ b/content/browser/service_worker/service_worker_metrics.cc

@@ -229,13 +229,16 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,

case EventType::PUSH:

UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PushEvent.Time", time);

break;

+ case EventType::MESSAGE:

+ // TODO(nhiroki): Record event duration for Message event after

+ // ExtendableMessageEvent is enabled by default (crbug.com/543198).

+ break;

// Event duration for fetch is recorded separately.

case EventType::FETCH:

// For now event duration for these events is not recorded.

case EventType::GEOFENCING:

case EventType::SERVICE_PORT_CONNECT:

- case EventType::MESSAGE:

break;

case EventType::NUM_TYPES: