Issue 25542. If an element does not have its own documentation, use the documentation from the over…

Issue 25542. If an element does not have its own documentation, use the documentation from the overridden superclass member or an implemented interface.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542

Committed: https://github.com/dart-lang/sdk/commit/e7e52ae2c05bed6567bfaf3c8b9c8918a466c6d7

[Brian Wilkerson, 2016-01-25 22:09:59]

LGTM

https://codereview.chromium.org/1632033002/diff/1/pkg/analysis_server/test/an...
File pkg/analysis_server/test/analysis/get_hover_test.dart (right):

https://codereview.chromium.org/1632033002/diff/1/pkg/analysis_server/test/an...
pkg/analysis_server/test/analysis/get_hover_test.dart:99:
test_dartdoc_inherited_methodByMethod_fromInterface() async {
I'll suggest a couple more tests.

(1) Indirectly overridden:

class A {
  // my doc
  m() {}
}
class B extends A {
  m() {}
}
class C extends B {
  m() {}
}

I would expect hovering over C.m to return the docs for A.m.

(2) Class over interface:

class A {
  // my doc
  m() {}
}
class B extends A {
}
class I {
  // wrong doc
  m() {}
}
class C extends B implements I {
  m() {}
}

I would expect hovering over C.m to return the doc for A.m.

[scheglov, 2016-01-26 00:52:50]

https://codereview.chromium.org/1632033002/diff/1/pkg/analysis_server/test/an...
File pkg/analysis_server/test/analysis/get_hover_test.dart (right):

https://codereview.chromium.org/1632033002/diff/1/pkg/analysis_server/test/an...
pkg/analysis_server/test/analysis/get_hover_test.dart:99:
test_dartdoc_inherited_methodByMethod_fromInterface() async {
On 2016/01/25 22:09:59, Brian Wilkerson wrote:
> I'll suggest a couple more tests.
> 
> (1) Indirectly overridden:
> 
> class A {
>   // my doc
>   m() {}
> }
> class B extends A {
>   m() {}
> }
> class C extends B {
>   m() {}
> }
> 
> I would expect hovering over C.m to return the docs for A.m.
> 
> (2) Class over interface:
> 
> class A {
>   // my doc
>   m() {}
> }
> class B extends A {
> }
> class I {
>   // wrong doc
>   m() {}
> }
> class C extends B implements I {
>   m() {}
> }
> 
> I would expect hovering over C.m to return the doc for A.m.

Done.

https://codereview.chromium.org/1632033002/diff/1/pkg/analysis_server/test/an...
pkg/analysis_server/test/analysis/get_hover_test.dart:99:
test_dartdoc_inherited_methodByMethod_fromInterface() async {
On 2016/01/25 22:09:59, Brian Wilkerson wrote:
> I'll suggest a couple more tests.
> 
> (1) Indirectly overridden:
> 
> class A {
>   // my doc
>   m() {}
> }
> class B extends A {
>   m() {}
> }
> class C extends B {
>   m() {}
> }
> 
> I would expect hovering over C.m to return the docs for A.m.
> 
> (2) Class over interface:
> 
> class A {
>   // my doc
>   m() {}
> }
> class B extends A {
> }
> class I {
>   // wrong doc
>   m() {}
> }
> class C extends B implements I {
>   m() {}
> }
> 
> I would expect hovering over C.m to return the doc for A.m.

Done.

[scheglov, 2016-01-26 01:09:52]

Description was changed from

==========
Issue 25542. If an element does not have its own documentation, use the
documentation from the overridden superclass member or an implemented interface.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542
==========

to

==========
Issue 25542. If an element does not have its own documentation, use the
documentation from the overridden superclass member or an implemented interface.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25542

Committed:
https://github.com/dart-lang/sdk/commit/e7e52ae2c05bed6567bfaf3c8b9c8918a466c6d7
==========

[scheglov, 2016-01-26 01:09:54]

Committed patchset #2 (id:20001) manually as
e7e52ae2c05bed6567bfaf3c8b9c8918a466c6d7 (presubmit successful).