Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_hover.dart

Issue 1632033002: Issue 25542. If an element does not have its own documentation, use the documentation from the over… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: New test cases and tweaks. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/computer/computer_overrides.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/computer_hover.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart
index 45467ca10933d700ffff61251fa1a3d92c55e685..02c4f706a889bd349f7d6ce0bf686d5da52fab56 100644
--- a/pkg/analysis_server/lib/src/computer/computer_hover.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart
@@ -6,6 +6,7 @@ library computer.hover;
import 'package:analysis_server/plugin/protocol/protocol.dart'
show HoverInformation;
+import 'package:analysis_server/src/computer/computer_overrides.dart';
import 'package:analysis_server/src/utilities/documentation.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/generated/ast.dart';
@@ -69,7 +70,6 @@ class DartUnitHoverComputer {
hover.containingLibraryPath = library.source.fullName;
}
}
-
// documentation
hover.dartdoc = _computeDocumentation(element);
}
@@ -91,7 +91,23 @@ class DartUnitHoverComputer {
if (element is ParameterElement) {
element = element.enclosingElement;
}
- return removeDartDocDelimiters(element.documentationComment);
+ // The documentation of the element itself.
+ if (element.documentationComment != null) {
+ return removeDartDocDelimiters(element.documentationComment);
+ }
+ // Look for documentation comments of overridden members.
+ OverriddenElements overridden = findOverriddenElements(element);
+ for (Element superElement in []
+ ..addAll(overridden.superElements)
+ ..addAll(overridden.interfaceElements)) {
+ String rawDoc = superElement.documentationComment;
+ if (rawDoc != null) {
+ Element interfaceClass = superElement.enclosingElement;
+ return removeDartDocDelimiters(rawDoc) +
+ '\n\nCopied from `${interfaceClass.displayName}`.';
+ }
+ }
+ return null;
}
static _safeToString(obj) => obj != null ? obj.toString() : null;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/computer/computer_overrides.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698