Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1631713002: [heap] Cleanup SemiSpace (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, ulan, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup SemiSpace - Remove semispace target capacity: It's unused and adds some unneeded complexity - Enforcing decl order for SemiSpace - Move forward declarations in spaces.h to top - Add all members to default constructor BUG=chromium:581076 LOG=N Committed: https://crrev.com/8391d425ed84ca41880543dad98b9fdfa3650d95 Cr-Commit-Position: refs/heads/master@{#33515}

Patch Set 1 : #

Patch Set 2 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -281 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 12 chunks +76 lines, -81 lines 0 comments Download
M src/heap/spaces.cc View 1 16 chunks +49 lines, -127 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Michael Lippautz
hpayer: PTAL jochen: fyi (or the other way round ;p -- no semantic changes, only ...
4 years, 11 months ago (2016-01-25 17:56:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631713002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631713002/80001
4 years, 11 months ago (2016-01-25 17:56:23 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/476) v8_linux_nodcheck_rel on ...
4 years, 11 months ago (2016-01-25 17:59:10 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631713002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631713002/100001
4 years, 11 months ago (2016-01-25 18:12:44 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 19:31:12 UTC) #17
Hannes Payer (out of office)
On 2016/01/25 19:31:12, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-26 13:46:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631713002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631713002/100001
4 years, 11 months ago (2016-01-26 13:48:18 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 11 months ago (2016-01-26 13:49:54 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:50:42 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8391d425ed84ca41880543dad98b9fdfa3650d95
Cr-Commit-Position: refs/heads/master@{#33515}

Powered by Google App Engine
This is Rietveld 408576698