Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: src/heap/heap.cc

Issue 1631713002: [heap] Cleanup SemiSpace (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/spaces.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 634d1b3c7d11b55d204c2a1c4649ae61ec1c1b27..d7f07b85eb0369689532f9d20271fe916c750ff9 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -77,7 +77,6 @@ Heap::Heap()
reserved_semispace_size_(8 * (kPointerSize / 4) * MB),
max_semi_space_size_(8 * (kPointerSize / 4) * MB),
initial_semispace_size_(Page::kPageSize),
- target_semispace_size_(Page::kPageSize),
max_old_generation_size_(700ul * (kPointerSize / 4) * MB),
initial_old_generation_size_(max_old_generation_size_ /
kInitalOldGenerationLimitFactor),
@@ -4748,31 +4747,6 @@ bool Heap::ConfigureHeap(int max_semi_space_size, int max_old_space_size,
initial_semispace_size_ = Min(initial_semispace_size_, max_semi_space_size_);
- if (FLAG_target_semi_space_size > 0) {
- int target_semispace_size = FLAG_target_semi_space_size * MB;
- if (target_semispace_size < initial_semispace_size_) {
- target_semispace_size_ = initial_semispace_size_;
- if (FLAG_trace_gc) {
- PrintIsolate(isolate_,
- "Target semi-space size cannot be less than the minimum "
- "semi-space size of %d MB\n",
- initial_semispace_size_ / MB);
- }
- } else if (target_semispace_size > max_semi_space_size_) {
- target_semispace_size_ = max_semi_space_size_;
- if (FLAG_trace_gc) {
- PrintIsolate(isolate_,
- "Target semi-space size cannot be less than the maximum "
- "semi-space size of %d MB\n",
- max_semi_space_size_ / MB);
- }
- } else {
- target_semispace_size_ = ROUND_UP(target_semispace_size, Page::kPageSize);
- }
- }
-
- target_semispace_size_ = Max(initial_semispace_size_, target_semispace_size_);
-
if (FLAG_semi_space_growth_factor < 2) {
FLAG_semi_space_growth_factor = 2;
}
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/spaces.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698