Fix net_unittests targets to pass on iOS using GN.

Fix net_unittests targets to pass on iOS using GN.

List all test file to copy to the application bundle and override
the application bundle id.

BUG=459705

[sdefresne, 2016-01-25 15:26:07]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-01-25 15:26:08]

Please take a look.

[Dirk Pranke, 2016-01-29 00:55:39]

lgtm but see my comments in https://codereview.chromium.org/1611363003/ about
the bundle_test_name syntax and also the desire to support directories in
tests_data_files

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
File build/secondary/third_party/nss/BUILD.gn (right):

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
build/secondary/third_party/nss/BUILD.gn:499: }
why this change?

[sdefresne, 2016-01-29 09:04:44]

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
File build/secondary/third_party/nss/BUILD.gn (right):

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
build/secondary/third_party/nss/BUILD.gn:499: }
On 2016/01/29 at 00:55:39, Dirk Pranke wrote:
> why this change?

I though I explained this in the CL description. Without the change, the
command-line looks like the following on iOS:

... -Wno-unused-function ... -Wall ...

where -Wall comes from //build/config/compiler:no_chromium_code while the
-Wno-unused-function comes from the cflags inlined in the target. This is
because the flags inlined in the targets comes before the one from dependent
config. By moving the flags into a private config, they end up after those
coming from //build/config/compiler:no_chromium_code and we end up with a
command-line that looks like this:

... -Wall ... -Wno-unused-function ...

In general the ordering of the flags would not be a problem, however, -Wall set
-Wunused-function and thus override the -Wno-unused-function from the target
cflags, and cause compilation failure due to the unused rng_systemFromNoise
function.

[sdefresne, 2016-01-29 10:30:31]

Description was changed from

==========
Fix net_unittests targets to pass on iOS using GN.

build/secondary/third_party/nss/BUILD.gn

  Move the cflags override into a separate config so that they are
  applied after those from //build/config/compiler:no_chromium_code
  (this config add -Wall that overrides the -Wno-unused-function).

net/BUILD.gn

  List all test file to copy to the application bundle and override
  the application bundle id.

BUG=459705
==========

to

==========
Fix net_unittests targets to pass on iOS using GN.

List all test file to copy to the application bundle and override
the application bundle id.

BUG=459705
==========

[sdefresne, 2016-01-29 10:58:21]

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
File build/secondary/third_party/nss/BUILD.gn (right):

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
build/secondary/third_party/nss/BUILD.gn:499: }
On 2016/01/29 at 09:04:44, sdefresne (OOO till Feb 1st) wrote:
> On 2016/01/29 at 00:55:39, Dirk Pranke wrote:
> > why this change?
> 
> I though I explained this in the CL description. Without the change, the
command-line looks like the following on iOS:
> 
> ... -Wno-unused-function ... -Wall ...
> 
> where -Wall comes from //build/config/compiler:no_chromium_code while the
-Wno-unused-function comes from the cflags inlined in the target. This is
because the flags inlined in the targets comes before the one from dependent
config. By moving the flags into a private config, they end up after those
coming from //build/config/compiler:no_chromium_code and we end up with a
command-line that looks like this:
> 
> ... -Wall ... -Wno-unused-function ...
> 
> In general the ordering of the flags would not be a problem, however, -Wall
set -Wunused-function and thus override the -Wno-unused-function from the target
cflags, and cause compilation failure due to the unused rng_systemFromNoise
function.

Extracted as a separate CL: https://codereview.chromium.org/1644333002

[Dirk Pranke, 2016-01-29 18:59:40]

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
File build/secondary/third_party/nss/BUILD.gn (right):

https://codereview.chromium.org/1631693002/diff/1/build/secondary/third_party...
build/secondary/third_party/nss/BUILD.gn:499: }
On 2016/01/29 09:04:44, sdefresne (OOO till Feb 1st) wrote:
> I though I explained this in the CL description.

Ah, right. Sorry for the confusion!

[Dirk Pranke, 2016-01-29 19:00:28]

lgtm w/ same comment as before about ideally just being able to use //net/data/
at some point. But, listing all the files is not necessarily bad, so we can land
as-is to make progress, too.

[sdefresne, 2016-03-16 13:16:12]

Obsolete.