Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1644333002: Fix compilation of //third_party/nss with gn on iOS. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of //third_party/nss with gn on iOS. Move the cflags override into a separate config so that they are applied after those from //build/config/compiler:no_chromium_code. Without this change, the -Wno-unused-function is found before the -Wall that set the -Wunused-function flag. By using a separate config, the flags are set in order, and the -Wno-unused-function is found after the -Wall. BUG=459705 Committed: https://crrev.com/f5d1a9c599c7cd6833455eacb4ec694a47c1f1b0 Cr-Commit-Position: refs/heads/master@{#372546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M build/secondary/third_party/nss/BUILD.gn View 3 chunks +25 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look. Fixes the following compilation failures: ../../third_party/nss/nss/lib/freebl/shvfy.c:226:1: error: unused function 'mkCheckFileName' [-Werror,-Wunused-function] ...
4 years, 10 months ago (2016-01-29 10:29:56 UTC) #2
Dirk Pranke
lgtm
4 years, 10 months ago (2016-01-29 18:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644333002/1
4 years, 10 months ago (2016-01-30 10:14:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 10:18:52 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 10:19:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5d1a9c599c7cd6833455eacb4ec694a47c1f1b0
Cr-Commit-Position: refs/heads/master@{#372546}

Powered by Google App Engine
This is Rietveld 408576698