Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1631663006: Ignore focus events on role client nodes. (Closed)

Created:
4 years, 11 months ago by David Tseng
Modified:
4 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore focus events on role client nodes. - switch tabs via ctrl+tab result: a node of role client triggers a focus event. It is a child of the toolbar in the desktop tree. expected: generic elements in the desktop tree like this one should not be focused. Notes: This focus event causes us to flip to compat temporarily but due to logic in TabsApiHandler, we switch right back to classic. However, since range was previously set to the client node (and compat flips off classic), we're stuck in a halfway state where classic mode is set but the content script was unloaded. Committed: https://crrev.com/e05e92d6be45e30894f0e4ed6a31e1725c310fcb Cr-Commit-Position: refs/heads/master@{#371588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
David Tseng
4 years, 11 months ago (2016-01-26 01:18:59 UTC) #3
dmazzoni
lgtm Thanks. This shouldn't be necessary as soon as I fix focus handling.
4 years, 11 months ago (2016-01-26 19:49:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631663006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631663006/1
4 years, 11 months ago (2016-01-26 19:50:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 20:41:28 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 20:43:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e05e92d6be45e30894f0e4ed6a31e1725c310fcb
Cr-Commit-Position: refs/heads/master@{#371588}

Powered by Google App Engine
This is Rietveld 408576698