chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js - Issue 1631663006: Ignore focus events on role client nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 1631663006: Ignore focus events on role client nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

index 11813ec6b8e32b42a746bece66eb4def1e4c1cb0..b96b3ac3fc1db5814abbb5050839429405e4c559 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

@@ -130,8 +130,8 @@ DesktopAutomationHandler.prototype = {

var node = evt.target;

- // Discard focus events on embeddedObject nodes.

- if (node.role == RoleType.embeddedObject)

+ // Discard focus events on embeddedObject and client nodes.

+ if (node.role == RoleType.embeddedObject || node.role == RoleType.client)

return;

// It almost never makes sense to place focus directly on a rootWebArea.

« no previous file with comments | « no previous file | no next file » | no next file with comments »