Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1631593003: [interpreter] Deprecate --ignition-fallback-on-catch flag. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Deprecate --ignition-fallback-on-catch flag. The current support for try-catch in the interpreter can handle most of the cases appearing in our test suite. Also the flag in question did not detect try-finally constructs. This removes the flag and instead extends the test expectations. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Committed: https://crrev.com/b707ca4b54d7fab779afb567693f7f18a77c248d Cr-Commit-Position: refs/heads/master@{#33494}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Adapt after rebase. #

Patch Set 4 : Adapt some more. #

Patch Set 5 : Adapt for ARM64. #

Patch Set 6 : One more timeout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -28 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 6 chunks +25 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-25 12:22:25 UTC) #1
rmcilroy
Awesome, thanks for removing the flag! lgtm.
4 years, 11 months ago (2016-01-25 12:24:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631593003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631593003/80001
4 years, 11 months ago (2016-01-25 15:20:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14386)
4 years, 11 months ago (2016-01-25 15:30:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631593003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631593003/100001
4 years, 11 months ago (2016-01-25 15:53:15 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-25 15:57:03 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 15:57:57 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b707ca4b54d7fab779afb567693f7f18a77c248d
Cr-Commit-Position: refs/heads/master@{#33494}

Powered by Google App Engine
This is Rietveld 408576698