Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: src/compiler.cc

Issue 1631593003: [interpreter] Deprecate --ignition-fallback-on-catch flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: One more timeout. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 5fcfccde20860f3fa6cad9e3fe4c372b3f07e722..f01f532f137ce83150b8cf90a163bfc259af68af 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -740,31 +740,12 @@ static bool CompileUnoptimizedCode(CompilationInfo* info) {
}
-// TODO(rmcilroy): Remove this temporary work-around when ignition supports
-// catch and eval.
-static bool IgnitionShouldFallbackToFullCodeGen(Scope* scope) {
- if (scope->is_catch_scope()) {
- return true;
- }
- for (auto inner_scope : *scope->inner_scopes()) {
- if (IgnitionShouldFallbackToFullCodeGen(inner_scope)) return true;
- }
- return false;
-}
-
-
static bool UseIgnition(CompilationInfo* info) {
// Cannot use Ignition when the {function_data} is already used.
if (info->has_shared_info() && info->shared_info()->HasBuiltinFunctionId()) {
return false;
}
- // Checks whether the scope chain is supported.
- if (FLAG_ignition_fallback_on_catch &&
- IgnitionShouldFallbackToFullCodeGen(info->scope())) {
- return false;
- }
-
// Checks whether top level functions should be passed by the filter.
if (info->closure().is_null()) {
Vector<const char> filter = CStrVector(FLAG_ignition_filter);
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698