Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1631413002: NaCl cleanup: Remove not-very-useful debug logging in the plugin code (Closed)

Created:
4 years, 11 months ago by Mark Seaborn
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove not-very-useful debug logging in the plugin code This removes all the PLUGIN_PRINTF/MODULE_PRINTF calls from components/nacl/renderer/plugin/. There aren't very many of these logging calls left now. They don't look useful to have in release binaries, and it's against Chromium style to keep this sort of logging in the code. Anyone doing debugging can manually add their own logging. My main motivation here is to remove a non-standard logging mechanism that depends on some native_client/ headers. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Committed: https://crrev.com/58c568b9327125473321742c277a26742d3eebd2 Cr-Commit-Position: refs/heads/master@{#371865}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -159 lines) Patch
M components/nacl/renderer/plugin/module_ppapi.cc View 4 chunks +1 line, -14 lines 0 comments Download
M components/nacl/renderer/plugin/plugin.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_coordinator.cc View 1 9 chunks +0 lines, -17 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_resources.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_translate_thread.cc View 1 12 chunks +0 lines, -19 lines 0 comments Download
M components/nacl/renderer/plugin/utility.h View 1 2 chunks +0 lines, -38 lines 0 comments Download
M components/nacl/renderer/plugin/utility.cc View 1 1 chunk +0 lines, -52 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631413002/1
4 years, 11 months ago (2016-01-26 20:44:03 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/159325)
4 years, 11 months ago (2016-01-26 21:23:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631413002/20001
4 years, 11 months ago (2016-01-27 18:27:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 19:11:50 UTC) #8
Mark Seaborn
4 years, 11 months ago (2016-01-27 20:14:11 UTC) #11
bbudge
lgtm
4 years, 11 months ago (2016-01-27 20:27:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631413002/20001
4 years, 11 months ago (2016-01-27 20:37:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 20:47:42 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 20:49:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58c568b9327125473321742c277a26742d3eebd2
Cr-Commit-Position: refs/heads/master@{#371865}

Powered by Google App Engine
This is Rietveld 408576698