Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 1631413002: NaCl cleanup: Remove not-very-useful debug logging in the plugin code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/nacl/renderer/ppb_nacl_private.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/renderer/ppb_nacl_private_impl.h" 5 #include "components/nacl/renderer/ppb_nacl_private_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <numeric> 9 #include <numeric>
10 #include <string> 10 #include <string>
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 return PP_FALSE; 891 return PP_FALSE;
892 IPC::Sender* sender = content::RenderThread::Get(); 892 IPC::Sender* sender = content::RenderThread::Get();
893 DCHECK(sender); 893 DCHECK(sender);
894 bool should_debug = false; 894 bool should_debug = false;
895 return PP_FromBool( 895 return PP_FromBool(
896 sender->Send(new NaClHostMsg_NaClDebugEnabledForURL(GURL(alleged_nmf_url), 896 sender->Send(new NaClHostMsg_NaClDebugEnabledForURL(GURL(alleged_nmf_url),
897 &should_debug)) && 897 &should_debug)) &&
898 should_debug); 898 should_debug);
899 } 899 }
900 900
901 void Vlog(const char* message) {
902 VLOG(1) << message;
903 }
904
905 void InitializePlugin(PP_Instance instance, 901 void InitializePlugin(PP_Instance instance,
906 uint32_t argc, 902 uint32_t argc,
907 const char* argn[], 903 const char* argn[],
908 const char* argv[]) { 904 const char* argv[]) {
909 NexeLoadManager* load_manager = GetNexeLoadManager(instance); 905 NexeLoadManager* load_manager = GetNexeLoadManager(instance);
910 DCHECK(load_manager); 906 DCHECK(load_manager);
911 if (load_manager) 907 if (load_manager)
912 load_manager->InitializePlugin(argc, argn, argv); 908 load_manager->InitializePlugin(argc, argn, argv);
913 } 909 }
914 910
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1707 &UrandomFD, 1703 &UrandomFD,
1708 &GetReadExecPnaclFd, 1704 &GetReadExecPnaclFd,
1709 &CreateTemporaryFile, 1705 &CreateTemporaryFile,
1710 &GetNumberOfProcessors, 1706 &GetNumberOfProcessors,
1711 &ReportTranslationFinished, 1707 &ReportTranslationFinished,
1712 &DispatchEvent, 1708 &DispatchEvent,
1713 &ReportLoadError, 1709 &ReportLoadError,
1714 &InstanceCreated, 1710 &InstanceCreated,
1715 &InstanceDestroyed, 1711 &InstanceDestroyed,
1716 &GetSandboxArch, 1712 &GetSandboxArch,
1717 &Vlog,
1718 &InitializePlugin, 1713 &InitializePlugin,
1719 &RequestNaClManifest, 1714 &RequestNaClManifest,
1720 &GetManifestBaseURL, 1715 &GetManifestBaseURL,
1721 &ProcessNaClManifest, 1716 &ProcessNaClManifest,
1722 &ManifestGetProgramURL, 1717 &ManifestGetProgramURL,
1723 &GetPNaClResourceInfo, 1718 &GetPNaClResourceInfo,
1724 &GetCpuFeatureAttrs, 1719 &GetCpuFeatureAttrs,
1725 &DownloadNexe, 1720 &DownloadNexe,
1726 &LogTranslateTime, 1721 &LogTranslateTime,
1727 &LogBytesCompiledVsDowloaded, 1722 &LogBytesCompiledVsDowloaded,
1728 &SetPNaClStartTime, 1723 &SetPNaClStartTime,
1729 &StreamPexe 1724 &StreamPexe
1730 }; 1725 };
1731 1726
1732 } // namespace 1727 } // namespace
1733 1728
1734 const PPB_NaCl_Private* GetNaClPrivateInterface() { 1729 const PPB_NaCl_Private* GetNaClPrivateInterface() {
1735 return &nacl_interface; 1730 return &nacl_interface;
1736 } 1731 }
1737 1732
1738 } // namespace nacl 1733 } // namespace nacl
OLDNEW
« no previous file with comments | « components/nacl/renderer/ppb_nacl_private.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698