Issue 16311010: Make FileSystemOperation::Write take closure-friendly parameters

Issue 16311010: Make FileSystemOperation::Write take closure-friendly parameters (Closed)

Created:
7 years, 6 months ago by kinuko

Modified:
7 years, 6 months ago

Reviewers:
tzik

CC:
chromium-reviews, stevenjb+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, oshima+watch_chromium.org, tzik+watch_chromium.org, nhiroki

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make FileSystemOperation::Write take closure-friendly parameters - Factor-out common Write implementation into FileSystemOperationRunner - Deprecate LocalFileSystemOperation::GetWriteClosure - Cleanup *FileSystemOperation::Write BUG=248890 TEST=FileWriterDelegateTest.*,LocalFileSystemOperationWriteTest.* R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206025

Patch Set 1 : #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -204 lines)			Patch
M	webkit/browser/chromeos/fileapi/remote_file_system_operation.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/browser/chromeos/fileapi/remote_file_system_operation.cc	View	2 chunks	+7 lines, -17 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation.h	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner.cc	View	2 chunks	+19 lines, -1 line	0 comments	Download
M	webkit/browser/fileapi/file_writer_delegate.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/file_writer_delegate.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/file_writer_delegate_unittest.cc	View	13 chunks	+100 lines, -86 lines	0 comments	Download
M	webkit/browser/fileapi/local_file_system_operation.h	View	4 chunks	+4 lines, -26 lines	0 comments	Download
M	webkit/browser/fileapi/local_file_system_operation.cc	View	3 chunks	+9 lines, -42 lines	0 comments	Download
M	webkit/browser/fileapi/syncable/syncable_file_system_operation.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/syncable/syncable_file_system_operation.cc	View	3 chunks	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

https://codereview.chromium.org/16311010/diff/4001/webkit/browser/fileapi/syncable/syncable_file_system_operation.cc File webkit/browser/fileapi/syncable/syncable_file_system_operation.cc (right): https://codereview.chromium.org/16311010/diff/4001/webkit/browser/fileapi/syncable/syncable_file_system_operation.cc#newcode8 webkit/browser/fileapi/syncable/syncable_file_system_operation.cc:8: #include "net/url_request/url_request_context.h" This one needs to be "net/url_request/url_request.h", to ...

7 years, 6 months ago (2013-06-12 14:25:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r206025.

Expand Messages | Collapse Messages