Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: webkit/browser/fileapi/local_file_system_operation.h

Issue 16311010: Make FileSystemOperation::Write take closure-friendly parameters (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/fileapi/local_file_system_operation.h
diff --git a/webkit/browser/fileapi/local_file_system_operation.h b/webkit/browser/fileapi/local_file_system_operation.h
index afb96b36ca8e5edd35adad9df2758d4878ef4790..3ad856c14caf3ba3f91291f11fdd5a5b5abbdd4e 100644
--- a/webkit/browser/fileapi/local_file_system_operation.h
+++ b/webkit/browser/fileapi/local_file_system_operation.h
@@ -18,14 +18,6 @@
#include "webkit/common/quota/quota_types.h"
#include "webkit/storage/webkit_storage_export.h"
-namespace chromeos {
-class CrosMountPointProvider;
-}
-
-namespace sync_file_system {
-class SyncableFileSystemOperation;
-}
-
namespace fileapi {
class AsyncFileUtil;
@@ -72,10 +64,9 @@ class WEBKIT_STORAGE_EXPORT LocalFileSystemOperation
const ReadDirectoryCallback& callback) OVERRIDE;
virtual void Remove(const FileSystemURL& url, bool recursive,
const StatusCallback& callback) OVERRIDE;
- virtual void Write(const net::URLRequestContext* url_request_context,
- const FileSystemURL& url,
- const GURL& blob_url,
- int64 offset,
+ virtual void Write(const FileSystemURL& url,
+ scoped_ptr<FileWriterDelegate> writer_delegate,
+ scoped_ptr<net::URLRequest> blob_request,
const WriteCallback& callback) OVERRIDE;
virtual void Truncate(const FileSystemURL& url, int64 length,
const StatusCallback& callback) OVERRIDE;
@@ -168,9 +159,7 @@ class WEBKIT_STORAGE_EXPORT LocalFileSystemOperation
return file_system_context_.get();
}
- private:
- friend class sync_file_system::SyncableFileSystemOperation;
-
+ protected:
// Queries the quota and usage and then runs the given |task|.
// If an error occurs during the quota query it runs |error_callback| instead.
void GetUsageAndQuotaThenRunTask(
@@ -189,17 +178,6 @@ class WEBKIT_STORAGE_EXPORT LocalFileSystemOperation
quota::QuotaStatusCode status,
int64 usage, int64 quota);
- // returns a closure which actually perform the write operation.
- base::Closure GetWriteClosure(
- const net::URLRequestContext* url_request_context,
- const FileSystemURL& url,
- const GURL& blob_url,
- int64 offset,
- const WriteCallback& callback);
- void DidFailWrite(
- const WriteCallback& callback,
- base::PlatformFileError result);
-
// The 'body' methods that perform the actual work (i.e. posting the
// file task on proxy_) after the quota check.
void DoCreateFile(const FileSystemURL& url,

Powered by Google App Engine
This is Rietveld 408576698