Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 163103002: Mark the x-webkit-speech input element attribute as deprecated (Closed)

Created:
5 years, 8 months ago by Tommy Widenflycht
Modified:
5 years, 8 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Mark the x-webkit-speech input element attribute as deprecated As discussed on blink-dev this change has been approved. Developers should switch to the JavaScript Speech recognition API instead. R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167076

Patch Set 1 #

Patch Set 2 : Trying to fix CRLF issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M LayoutTests/fast/forms/input-type-change-focusout-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-user-modify-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/textfield-clone-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/bubble-position-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/bubble-position-scrolled-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/change-focus-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-onspeechchange-event-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-ontextinput-event-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-readonly-and-disabled-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-text-language-tag-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-text-speechbutton-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/input-text-speechstart-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/speech-button-ignore-generated-events-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/speech-input-result-list-not-enough-arguments-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/speech/speech-input-scripting-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/speech/input-appearance-numberandspeech-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/speech/input-appearance-searchandspeech-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/speech/input-appearance-speechbutton-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/speech/speech-bidi-rendering-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tommy Widenflycht
5 years, 8 months ago (2014-02-13 08:12:29 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2014-02-13 08:56:45 UTC) #2
Tommy Widenflycht
5 years, 8 months ago (2014-02-13 10:16:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r167076 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698