Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter
Patch Set: de-dup is_win blocks in GN too Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/main_dll_loader_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_crash_reporter_client.cc
diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc
index e7a0103f2d44cbe6bda2e2b0c534765eb4456011..2a8db668a314983955ec33ed1ffc258004910159 100644
--- a/chrome/app/chrome_crash_reporter_client.cc
+++ b/chrome/app/chrome_crash_reporter_client.cc
@@ -12,7 +12,6 @@
#include "base/strings/string_split.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
-#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_paths_internal.h"
#include "chrome/common/chrome_result_codes.h"
@@ -26,6 +25,7 @@
#include "base/file_version_info.h"
#include "base/win/registry.h"
+#include "chrome/common/metrics_constants_util_win.h"
#include "chrome/installer/util/google_chrome_sxs_distribution.h"
#include "chrome/installer/util/install_util.h"
#include "chrome/installer/util/util_constants.h"
@@ -194,9 +194,7 @@ void ChromeCrashReporterClient::InitBrowserCrashDumpsRegKey() {
#if !defined(NACL_WIN64)
if (GetCollectStatsConsent()){
crash_reporting_metrics_.reset(new browser_watcher::CrashReportingMetrics(
- InstallUtil::IsChromeSxSProcess()
- ? chrome::kBrowserCrashDumpAttemptsRegistryPathSxS
- : chrome::kBrowserCrashDumpAttemptsRegistryPath));
+ chrome::GetBrowserCrashDumpAttemptsRegistryPath()));
}
#endif
}
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/main_dll_loader_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698