chrome/BUILD.gn - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: de-dup is_win blocks in GN too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index c6288239834261602d00f0f2104a5626ff6e7bc5..92ad74569a349eabb3a22d2de80a0b5be0a102eb 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -134,6 +134,8 @@ if (!is_android) {

"//chrome/browser:chrome_process_finder",

"//chrome/chrome_watcher",

"//chrome/chrome_watcher:client",

+ "//chrome/common:constants",

+ "//chrome/common:metrics_constants_util_win",

"//chrome/installer/util:with_no_strings",

"//chrome_elf",

"//components/browser_watcher:browser_watcher_client",

« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client.cc » ('j') | no next file with comments »