chrome/app/main_dll_loader_win.cc - Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/main_dll_loader_win.cc

Issue 1630923002: Remove PRODUCT_STRING_PATH from chrome_constants.h on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@c2_rm_PSP_profile_resetter

Patch Set: merge up to r379824 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/main_dll_loader_win.cc

diff --git a/chrome/app/main_dll_loader_win.cc b/chrome/app/main_dll_loader_win.cc

index 8d8f978bd3f3702f464d8a5c1e0ed34cd66ee6a8..41a1430ee3870377bdde5017556a4de9f32210f0 100644

--- a/chrome/app/main_dll_loader_win.cc

+++ b/chrome/app/main_dll_loader_win.cc

@@ -33,6 +33,7 @@

#include "chrome/app/kasko_client.h"

#include "chrome/chrome_watcher/chrome_watcher_main_api.h"

#include "chrome/common/chrome_constants.h"

+#include "chrome/common/chrome_constants_util_win.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_result_codes.h"

gab 2016/03/09 20:29:35 Interesting, another uncaught violation: "chrome/c

#include "chrome/common/chrome_switches.h"

@@ -164,8 +165,8 @@ int MainDllLoader::Launch(HINSTANCE instance) {

reinterpret_cast<ChromeWatcherMainFunction>(

::GetProcAddress(watcher_dll, kChromeWatcherDLLEntrypoint));

return watcher_main(

- chrome::kBrowserExitCodesRegistryPath, parent_process.Take(),

- main_thread_id, on_initialized_event.Take(),

+ chrome::GetBrowserExitCodesRegistryPath().c_str(),

+ parent_process.Take(), main_thread_id, on_initialized_event.Take(),

watcher_data_directory.value().c_str(), channel_name.c_str());

}

« no previous file with comments | « chrome/app/chrome_crash_reporter_client.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | chrome/common/BUILD.gn » ('J')