Clean up register+immediate addresses in ARM.

Clean up register+immediate addresses in ARM.

Cleans up the integrated ARM assembler, and its handling of register
memory addresses that can be modified by an immediate value. Handles
each possible encoding of such memory addresses.

Also adds assertions to check that the immediate value has the proper
range for the immediate value, based on the corresponding encoding.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=18273c0f6878b1b88fa4fffdae5c14f36631c511

[Karl, 2016-01-25 19:02:21]

Description was changed from

==========
Clean up register+immediate addresses in ARM.

Cleans up the integrated ARM assembler, and its handling of register
memory addresses that can be modified by an immediate value. Handles
each possible encoding of such memory addresses.

Also adds assertions to check that the immediate value has the proper
range for the immediate value, based on the corresponding encoding.

BUG=None
==========

to

==========
Clean up register+immediate addresses in ARM.

Cleans up the integrated ARM assembler, and its handling of register
memory addresses that can be modified by an immediate value. Handles
each possible encoding of such memory addresses.

Also adds assertions to check that the immediate value has the proper
range for the immediate value, based on the corresponding encoding.

BUG=None
==========

[Karl, 2016-01-25 19:02:21]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-01-25 20:37:50]

lgtm

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:207: // Alternate encoding for RotatedImm8Address,
where the offset is divided by 4
Optional: Consider adding a blank line after each enum value, to make it easier
to associate the comment with the correct enum value.

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:365: inline IValueT encodeImmRegOffset(IValueT Reg,
IOffsetT Offset,
Why inline here?  This seems inconsistent with the other functions here.

[Karl, 2016-01-25 23:58:58]

Description was changed from

==========
Clean up register+immediate addresses in ARM.

Cleans up the integrated ARM assembler, and its handling of register
memory addresses that can be modified by an immediate value. Handles
each possible encoding of such memory addresses.

Also adds assertions to check that the immediate value has the proper
range for the immediate value, based on the corresponding encoding.

BUG=None
==========

to

==========
Clean up register+immediate addresses in ARM.

Cleans up the integrated ARM assembler, and its handling of register
memory addresses that can be modified by an immediate value. Handles
each possible encoding of such memory addresses.

Also adds assertions to check that the immediate value has the proper
range for the immediate value, based on the corresponding encoding.

BUG=None
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-25 23:59:00]

Committed patchset #2 (id:20001) manually as
18273c0f6878b1b88fa4fffdae5c14f36631c511 (presubmit successful).

[Karl, 2016-01-25 23:59:16]

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:207: // Alternate encoding for RotatedImm8Address,
where the offset is divided by 4
On 2016/01/25 20:37:50, stichnot wrote:
> Optional: Consider adding a blank line after each enum value, to make it
easier
> to associate the comment with the correct enum value.

Added blank lines. Did same for following enum EncodedOperand.

https://codereview.chromium.org/1630863002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:365: inline IValueT encodeImmRegOffset(IValueT Reg,
IOffsetT Offset,
On 2016/01/25 20:37:50, stichnot wrote:
> Why inline here?  This seems inconsistent with the other functions here.

Removed.