Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 16305020: Merge 151430 "REGRESSION: Select listbox dispatches a change eve..." (Closed)

Created:
7 years, 6 months ago by tkent
Modified:
7 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews
Visibility:
Public.

Description

Merge 151430 "REGRESSION: Select listbox dispatches a change eve..." > REGRESSION: Select listbox dispatches a change event on scroll. > > wkrev.com/143560 fixed mouse events on scrollbars, and broke an > HTMLSelectElement assumption that mouseup event always happens on an > <option> element. So, listBoxOnChange() was called unexpectedly. > > This patch avoids this problem by checking > m_lastOnChangeSelection.isEmpty(), which means we didn't start click > or drag in this <select> element. > > BUG=244406 > TEST=automated > R=keishi@chromium.org > > Review URL: https://codereview.chromium.org/16184002 TBR=tkent@chromium.org BUG=244406 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --2 lines) Patch
LayoutTests/fast/forms/select/listbox-click-on-scrollbar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
LayoutTests/fast/forms/select/listbox-click-on-scrollbar-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
7 years, 6 months ago (2013-06-03 21:36:52 UTC) #1
tkent
Committed patchset #1 manually as r151689.
7 years, 6 months ago (2013-06-03 21:37:38 UTC) #2
tkent
7 years, 6 months ago (2013-06-03 22:28:56 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698